]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/os/seastore: remove laddr_t alignment check
authorZhang Song <zhangsong02@qianxin.com>
Thu, 22 Aug 2024 12:49:10 +0000 (20:49 +0800)
committerZhang Song <zhangsong02@qianxin.com>
Fri, 23 Aug 2024 11:19:38 +0000 (19:19 +0800)
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
src/crimson/os/seastore/object_data_handler.cc
src/crimson/os/seastore/transaction_manager.h

index 8e6f06b79ee55cb35ab57a3f970006db0e6d721b..f27fb0b006f21fc787156e472f8ca4acc957dbea 100644 (file)
@@ -520,7 +520,6 @@ ObjectDataHandler::write_ret do_insertions(
     [ctx](auto &region) {
       LOG_PREFIX(object_data_handler.cc::do_insertions);
       if (region.is_data()) {
-       ceph_assert(region.addr.is_aligned(ctx.tm.get_block_size()));
        assert_aligned(region.len);
        ceph_assert(region.len == region.bl->length());
        DEBUGT("allocating extent: {}~{}",
@@ -726,11 +725,6 @@ public:
 private:
   // refer to overwrite_plan_t description
   void validate() const {
-    ceph_assert(pin_begin.is_aligned(block_size));
-    ceph_assert(pin_end.is_aligned(block_size));
-    ceph_assert(aligned_data_begin.is_aligned(block_size));
-    ceph_assert(aligned_data_end.is_aligned(block_size));
-
     ceph_assert(pin_begin <= aligned_data_begin);
     ceph_assert(aligned_data_begin <= data_begin);
     ceph_assert(data_begin <= data_end);
@@ -1208,8 +1202,6 @@ extent_to_write_list_t get_to_writes_with_zero_buffer(
     (!tailptr && (right == zero_right)));
 
   assert(right > left);
-  assert(left.is_aligned(block_size));
-  assert(right.is_aligned(block_size));
 
   // zero region too small for a reserved section,
   // headptr and tailptr in same extent
@@ -1324,7 +1316,6 @@ ObjectDataHandler::write_ret ObjectDataHandler::overwrite(
           if (headptr) {
             write_bl.append(*headptr);
             write_offset = write_offset - headptr->length();
-           ceph_assert(write_offset.is_aligned(ctx.tm.get_block_size()));
           }
           write_bl.claim_append(*bl);
           if (tailptr) {
index b245cf6dcf34aaa165c993291948a75a40e136fd..2bd41bb5ab65b3ba03f1854705015a38ec3c12fb 100644 (file)
@@ -348,7 +348,6 @@ public:
     LOG_PREFIX(TransactionManager::alloc_non_data_extent);
     SUBTRACET(seastore_tm, "{} len={}, placement_hint={}, laddr_hint={}",
               t, T::TYPE, len, placement_hint, laddr_hint);
-    ceph_assert(laddr_hint.is_aligned(epm->get_block_size()));
     auto ext = cache->alloc_new_non_data_extent<T>(
       t,
       len,
@@ -388,7 +387,6 @@ public:
     LOG_PREFIX(TransactionManager::alloc_data_extents);
     SUBTRACET(seastore_tm, "{} len={}, placement_hint={}, laddr_hint={}",
               t, T::TYPE, len, placement_hint, laddr_hint);
-    ceph_assert(laddr_hint.is_aligned(epm->get_block_size()));
     auto exts = cache->alloc_new_data_extents<T>(
       t,
       len,
@@ -582,7 +580,6 @@ public:
     extent_len_t len) {
     LOG_PREFIX(TransactionManager::reserve_region);
     SUBDEBUGT(seastore_tm, "len={}, laddr_hint={}", t, len, hint);
-    ceph_assert(hint.is_aligned(epm->get_block_size()));
     return lba_manager->reserve_region(
       t,
       hint,
@@ -615,7 +612,6 @@ public:
     LOG_PREFIX(TransactionManager::clone_pin);
     SUBDEBUGT(seastore_tm, "len={}, laddr_hint={}, clone_offset {}",
       t, mapping.get_length(), hint, intermediate_key);
-    ceph_assert(hint.is_aligned(epm->get_block_size()));
     return lba_manager->clone_mapping(
       t,
       hint,