]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ReplicatedPG: remove faulty scrub assert in sub_op_modify_applied
authorSamuel Just <sam.just@inktank.com>
Tue, 3 Jul 2012 18:23:16 +0000 (11:23 -0700)
committerSamuel Just <sam.just@inktank.com>
Tue, 3 Jul 2012 18:30:44 +0000 (11:30 -0700)
This assert assumed that all ops submitted before MOSDRepScrub was
submitted were processed by the time that MOSDRepScrub was
processed.  In fact, MOSDRepScrub's scrub_to may refer to a
last_update yet to be seen by the replica.

Bug #2693

Signed-off-by: Samuel Just <sam.just@inktank.com>
src/osd/ReplicatedPG.cc

index a2a0efcdce98ed6af6acb476e8af1875944964c1..933bdb5992819d4c78bdcf1f34843dff19c2f964 100644 (file)
@@ -4286,7 +4286,6 @@ void ReplicatedPG::sub_op_modify_applied(RepModify *rm)
   last_update_applied = m->version;
   if (finalizing_scrub) {
     assert(active_rep_scrub);
-    assert(info.last_update <= active_rep_scrub->scrub_to);
     if (last_update_applied == active_rep_scrub->scrub_to) {
       osd->rep_scrub_wq.queue(active_rep_scrub);
       active_rep_scrub = 0;