mon/Monitor: remove unused variable

and add error handling

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc
index d28e21a746f759c8db6d375fe391bb165d8fd6ce..c2198638de2498b6442acf42e25e3f9b84a4aa51 100644 (file)
--- a/src/mon/Monitor.cc
+++ b/src/mon/Monitor.cc
@@ -5378,11 +5378,13 @@ void Monitor::get_all_versions(std::map<string, list<string> > &versions)
 
 void Monitor::get_versions(std::map<string, list<string> > &versions)
 {
-  int i = 0;
   for (auto& [rank, metadata] : mon_metadata) {
     auto q = metadata.find("ceph_version_short");
+    if (q == metadata.end()) {
+      // not likely
+      continue;
+    }
     versions[q->second].push_back(string("mon.") + monmap->get_name(rank));
-    i = i + 1;
   }
 }