]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
cephadm: Remove assignment to member variable in ServiceSpecs
authorVolker Theile <vtheile@suse.com>
Wed, 9 Sep 2020 16:08:17 +0000 (18:08 +0200)
committerNathan Cutler <ncutler@suse.com>
Tue, 6 Oct 2020 09:40:53 +0000 (11:40 +0200)
Remove unnecessary assignment to member variable 'preview_only', this is done in the constructor of the derived ServiceSpec class.

Fixes: https://tracker.ceph.com/issues/47384
Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 6443ac5efa9816da580fe8546942af0cdf4ed271)

src/python-common/ceph/deployment/service_spec.py

index 93c7611d4bce36afb6edc25f30b8f79fa3fd0a06..3dadb51dc2ddf6fa92e0d7305e719894de8793b8 100644 (file)
@@ -590,8 +590,6 @@ class NFSServiceSpec(ServiceSpec):
         #: RADOS namespace where NFS client recovery data is stored in the pool.
         self.namespace = namespace
 
-        self.preview_only = preview_only
-
     def validate(self):
         super(NFSServiceSpec, self).validate()
 
@@ -661,7 +659,6 @@ class RGWSpec(ServiceSpec):
         self.rgw_frontend_ssl_certificate = rgw_frontend_ssl_certificate
         self.rgw_frontend_ssl_key = rgw_frontend_ssl_key
         self.ssl = ssl
-        self.preview_only = preview_only
 
     def get_port(self):
         if self.rgw_frontend_port:
@@ -725,7 +722,6 @@ class IscsiServiceSpec(ServiceSpec):
         self.api_secure = api_secure
         self.ssl_cert = ssl_cert
         self.ssl_key = ssl_key
-        self.preview_only = preview_only
 
         if not self.api_secure and self.ssl_cert and self.ssl_key:
             self.api_secure = True