mon: Monitor: add is_noforward() helper to MonCommand

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc
index 298624e6228b588244ae528b50d24189bc8914f2..9d6f1079f91b7777fa1344d9ff2e21c03802894e 100644 (file)
--- a/src/mon/Monitor.cc
+++ b/src/mon/Monitor.cc
@@ -2611,7 +2611,7 @@ void Monitor::handle_command(MMonCommand *m)
                                               ARRAY_SIZE(mon_commands));
   if (!is_leader()) {
     if (!mon_cmd) {
-      if (leader_cmd->has_flag(MonCommand::FLAG_NOFORWARD)) {
+      if (leader_cmd->is_noforward()) {
        reply_command(m, -EINVAL,
                      "command not locally supported and not allowed to forward",
                      0);
@@ -2622,7 +2622,7 @@ void Monitor::handle_command(MMonCommand *m)
       forward_request_leader(m);
       return;
     } else if (!mon_cmd->is_compat(leader_cmd)) {
-      if (mon_cmd->has_flag(MonCommand::FLAG_NOFORWARD)) {
+      if (mon_cmd->is_noforward()) {
        reply_command(m, -EINVAL,
                      "command not compatible with leader and not allowed to forward",
                      0);
@@ -2642,7 +2642,7 @@ void Monitor::handle_command(MMonCommand *m)
     return;
   }
 
-  if (session->proxy_con && mon_cmd->has_flag(MonCommand::FLAG_NOFORWARD)) {
+  if (session->proxy_con && mon_cmd->is_noforward()) {
     dout(10) << "Got forward for noforward command " << m << dendl;
     reply_command(m, -EINVAL, "forward for noforward command", rdata, 0);
     return;

diff --git a/src/mon/Monitor.h b/src/mon/Monitor.h
index 585e8f3f1bf866f7e1bef88dc76e38f10474006c..879bdc00f403367f1cebec599d9ace6198b167cb 100644 (file)
--- a/src/mon/Monitor.h
+++ b/src/mon/Monitor.h
@@ -979,6 +979,10 @@ struct MonCommand {
        availability == o->availability;
   }
 
+  bool is_noforward() const {
+    return has_flag(MonCommand::FLAG_NOFORWARD);
+  }
+
   bool is_obsolete() const {
     return has_flag(MonCommand::FLAG_OBSOLETE);
   }