]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard: refactor back button event
authorTatjana Dehler <tdehler@suse.com>
Thu, 5 Nov 2020 13:26:59 +0000 (14:26 +0100)
committerTatjana Dehler <tdehler@suse.com>
Mon, 23 Nov 2020 09:11:02 +0000 (10:11 +0100)
Convert the `back` input event into a `backAction` output
event in order to be a bit more flexible with implementing
th actual back action.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
32 files changed:
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-discovery-modal/iscsi-target-discovery-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-image-settings-modal/iscsi-target-image-settings-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-iqn-settings-modal/iscsi-target-iqn-settings-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/bootstrap-create-modal/bootstrap-create-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/bootstrap-import-modal/bootstrap-import-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/edit-site-name-modal/edit-site-name-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/pool-edit-mode-modal/pool-edit-mode-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/pool-edit-peer-modal/pool-edit-peer-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-namespace-form/rbd-namespace-form-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-snapshot-form/rbd-snapshot-form-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-trash-move-modal/rbd-trash-move-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-trash-purge-modal/rbd-trash-purge-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-trash-restore-modal/rbd-trash-restore-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-creation-preview-modal/osd-creation-preview-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-devices-selection-modal/osd-devices-selection-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-flags-indiv-modal/osd-flags-indiv-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-flags-modal/osd-flags-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-pg-scrub-modal/osd-pg-scrub-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-reweight-modal/osd-reweight-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-scrub-modal/osd-scrub-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/prometheus/silence-matcher-modal/silence-matcher-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/crush-rule-form-modal/crush-rule-form-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/erasure-code-profile-form/erasure-code-profile-form-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-capability-modal/rgw-user-capability-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-s3-key-modal/rgw-user-s3-key-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-subuser-modal/rgw-user-subuser-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-swift-key-modal/rgw-user-swift-key-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/shared/components/back-button/back-button.component.ts
src/pybind/mgr/dashboard/frontend/src/app/shared/components/confirmation-modal/confirmation-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/shared/components/critical-confirmation-modal/critical-confirmation-modal.component.html
src/pybind/mgr/dashboard/frontend/src/app/shared/components/form-modal/form-modal.component.html

index e27c6a5a265197837c7595a0a5f25a48cf3b85c0..f4189cc372b45c4a4faa53a475a96a21fdc0a263 100644 (file)
                           [form]="discoveryForm"
                           *ngIf="hasPermission"
                           i18n>Submit</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index 21d8d00e213a52460c7a7933a3b690f5305c3025..b3732d2f5970ddf08491aeaabd34761dde7b43ee 100644 (file)
@@ -86,7 +86,7 @@
         <cd-submit-button i18n
                           [form]="settingsForm"
                           (submitAction)="save()">Confirm</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index 2df24f42c637aa397a6efff55f22407c1eac9c9e..76490e1d4deae2ab7adaf174d13856d7ba3b2d2d 100644 (file)
@@ -26,7 +26,7 @@
         <cd-submit-button i18n
                           [form]="settingsForm"
                           (submitAction)="save()">Confirm</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index 3e2a1867ae3c334752e4b23d226d131312744d47..6ab22cc70f7e4f5701026a8270c5b13c80e75d34 100755 (executable)
@@ -82,7 +82,7 @@
       </div>
 
       <div class="modal-footer">
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Close"
                         i18n-name>
         </cd-back-button>
index 9f901d98ec954898761ddc3fa450f69ad8d6f133..00a3745362dbf1e5fd6b6ed62268497484527d46 100644 (file)
@@ -90,7 +90,7 @@
         <cd-submit-button i18n
                           [form]="importBootstrapForm"
                           (submitAction)="import()">Import</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Close"
                         i18n-name>
         </cd-back-button>
index 09f97bfa54f7f81c743a82e061f074797b0d3eb1..403a5d8cd3af6f2f339191d6db73150ad340e8da 100644 (file)
@@ -33,7 +33,7 @@
         <cd-submit-button i18n
                           [form]="editSiteNameForm"
                           (submitAction)="update()">Update</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index 7facf5ba9b463c865196d1c477e01f8ab26670f8..98bb65c9f1ced2028ebd211f7cd74e8a3bc70a12 100644 (file)
@@ -37,7 +37,7 @@
         <cd-submit-button i18n
                           [form]="editModeForm"
                           (submitAction)="update()">Update</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index b563faed1e8907f009e46af01159aab03615425e..164791e996aa2f21eae2e2fc616d5e9e07e7669d 100644 (file)
@@ -94,7 +94,7 @@
         <cd-submit-button i18n
                           [form]="editPeerForm"
                           (submitAction)="update()">Submit</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index c7a339f344b8b05833e89475322f012fcb4de5c2..613a14b533500652e55fef9a985e4af0de6dce16 100644 (file)
@@ -73,7 +73,7 @@
         <cd-submit-button [form]="namespaceForm"
                           (submitAction)="submit()"
                           i18n>Create Namespace</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Close"
                         i18n-name>
         </cd-back-button>
index ce948ed8d45c60d6edf888ce46c7a1e13443c4da..1b58ee3610a78c9f2fa357e93507ed69866d8a3f 100644 (file)
@@ -33,7 +33,7 @@
                           i18n="form action button|Example: Create rbdSnapshot@@formActionButton"
                           (submitAction)="submit()">{{ action | titlecase }}
           {{ resource | upperFirst }}</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Close"
                         i18n-name>
         </cd-back-button>
index 588bc78c47e806fe6545a49fae0ffec52040d9dd..c53e79ac3df043e1a710a2e21811c2923e1d1396 100644 (file)
@@ -47,7 +47,7 @@
         <cd-submit-button i18n
                           [form]="moveForm"
                           (submitAction)="moveImage()">Move Image</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index 692014a386299a9042ec2e71ee1e1fcca8e249bc..989b69473b6a69cdc1b99af934967f5d3ef749af 100644 (file)
@@ -43,7 +43,7 @@
                           [form]="purgeForm"
                           (submitAction)="purge()"
                           i18n>Purge Trash</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index 6aa4105d0d0cd5a7ec0323b02d69b15e85c0f493..056ed2509ce3bd6392efddb43b8eabae186a9ecb 100644 (file)
@@ -37,7 +37,7 @@
         <cd-submit-button [form]="restoreForm"
                           (submitAction)="restore()"
                           i18n>Restore Image</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index bbbe426a45e63ab9640fb44080f11ea44ee18ad0..3431b84d3fc8c42b0cef6a402f4f50602ba9d424 100644 (file)
@@ -13,7 +13,7 @@
       <div class="modal-footer">
         <cd-submit-button (submitAction)="onSubmit()"
                           [form]="formGroup">{{ action | titlecase }}</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"></cd-back-button>
+        <cd-back-button (backAction)="activeModal.close()"></cd-back-button>
       </div>
     </form>
   </ng-container>
index ce323c7d61aa3f1f0e9c6ddf8ea40dd198a0591b..2cbf29bb249807b4bc2db76c03720997ebaf5a86 100644 (file)
@@ -34,7 +34,7 @@
         <cd-submit-button (submitAction)="onSubmit()"
                           [form]="formGroup"
                           [disabled]="!canSubmit || filteredDevices.length === 0">{{ action | titlecase }}</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"></cd-back-button>
+        <cd-back-button (backAction)="activeModal.close()"></cd-back-button>
       </div>
     </form>
   </ng-container>
index c392b8346c52899910071a3f4aed2b9a49ee65de..78d108d7be4ecab105e612c7b3b913ce0b5713e0 100644 (file)
@@ -42,7 +42,7 @@
                           (submitAction)="submitAction()"
                           [form]="osdFlagsForm"
                           i18n>Submit</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index 0b39576b7d338ee1db394498a1a114c545612e32..df3a3a192643322aec973ec16ab69eba4844fb6e 100644 (file)
@@ -35,7 +35,7 @@
                           (submitAction)="submitAction()"
                           [form]="osdFlagsForm"
                           i18n>Submit</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index 14b51cc67073a8655a16df63884c8ab3bc78682c..59c6d81fe04d3cf71aa50c93c9be441734bc7523 100644 (file)
@@ -38,7 +38,7 @@
                           (submitAction)="submitAction()"
                           i18n="form action button|Example: Create Pool@@formActionButton"
                           [form]="osdPgScrubForm">{{ action | titlecase }} {{ resource | upperFirst }}</cd-submit-button>
-        <cd-back-button [back]="activeModal.close">
+        <cd-back-button (backAction)="activeModal.close()">
         </cd-back-button>
       </div>
     </form>
index 892df49b9abe3573ced4f66e6d0bae7d96135090..6b444b0ee3144851aff48108abc971e7bbd199be 100755 (executable)
@@ -86,7 +86,7 @@
                           (submitAction)="submitAction()"
                           [form]="osdRecvSpeedForm"
                           i18n>Submit</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index 34b47b30836090837a407b556488ed1eaa2260fa..e19a3d8ceccc3af65ad6150e57a7aa7fb583ea22 100644 (file)
@@ -33,7 +33,7 @@
                           [form]="reweightForm"
                           [disabled]="reweightForm.invalid"
                           i18n>Reweight</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index 6f135adf17ceedc86bba6646f3942af0b9f72961..386d53a9173e246bc9bc5a45d35151bbfc389de7 100644 (file)
@@ -16,7 +16,7 @@
         <cd-submit-button (submitAction)="scrub()"
                           [form]="scrubForm"
                           i18n>Submit</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index c849c79d3166cd70bb9eb57710b52279cb1a40c5..b0c1798b99311d7cf68a5393d85deb687ab992b5 100644 (file)
@@ -80,7 +80,7 @@
                           [form]="form">
           <span i18n>{editMode, select, true {Edit} other {Add}}</span>
         </cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Close"
                         i18n-name>
         </cd-back-button>
index 546a5ec437ab98e4c14ca483806fc7282cf8a501..a29ac0e3342aad7186a7700da2f63e05e1143d87 100644 (file)
         <cd-submit-button (submitAction)="onSubmit()"
                           i18n="form action button|Example: Create Pool@@formActionButton"
                           [form]="frm">{{ action | titlecase }} {{ resource | upperFirst }}</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"></cd-back-button>
+        <cd-back-button (backAction)="activeModal.close()"></cd-back-button>
       </div>
     </form>
   </ng-container>
index 0ce41105e4e0b9761a1a2e6f469183f2959b18f1..4ed4025601b8e2141aef880ffc177e39ff0a270f 100644 (file)
         <cd-submit-button (submitAction)="onSubmit()"
                           i18n="form action button|Example: Create Pool@@formActionButton"
                           [form]="frm">{{ action | titlecase }} {{ resource | upperFirst }}</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"></cd-back-button>
+        <cd-back-button (backAction)="activeModal.close()"></cd-back-button>
       </div>
     </form>
   </ng-container>
index e07155637f115fa880fccbf68965dedc4ade3476..215c0cb61d013f5513971a67923beda9b737ae00 100644 (file)
@@ -64,7 +64,7 @@
         <cd-submit-button (submitAction)="onSubmit()"
                           i18n="form action button|Example: Create Pool@@formActionButton"
                           [form]="formGroup">{{ action | titlecase }} {{ resource | upperFirst }}</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"></cd-back-button>
+        <cd-back-button (backAction)="activeModal.close()"></cd-back-button>
       </div>
     </form>
   </ng-container>
index a6f73722dcebe7366808dcb24bc7f71ffd9d3790..a96a26753df2e0cad66eda147dd3a7152ab20660 100644 (file)
                           (submitAction)="onSubmit()"
                           i18n="form action button|Example: Create Pool@@formActionButton"
                           [form]="formGroup">{{ action | titlecase }} {{ resource | upperFirst }}</cd-submit-button>
-        <cd-back-button [back]="activeModal.close"></cd-back-button>
+        <cd-back-button (backAction)="activeModal.close()"></cd-back-button>
       </div>
     </form>
   </ng-container>
index 7ad3d10962d8f438e69d69a07b5f1b1c401b6025..8bb3363d3219e9b08df50435c6eb05c0cf52bbc2 100644 (file)
         <cd-submit-button (submitAction)="onSubmit()"
                           i18n="form action button|Example: Create Pool@@formActionButton"
                           [form]="formGroup">{{ action | titlecase }} {{ resource | upperFirst }}</cd-submit-button>
-        <cd-back-button [back]="bsModalRef.close"></cd-back-button>
+        <cd-back-button (backAction)="bsModalRef.close()"></cd-back-button>
       </div>
     </form>
   </ng-container>
index 1db2ef23cafc6d55262732d0acfbfb3fd431712b..8121dbc31e377b79c7e5e907fb44fc9b4e6cd9ee 100644 (file)
@@ -51,7 +51,7 @@
     </div>
 
     <div class="modal-footer">
-      <cd-back-button [back]="activeModal.close"></cd-back-button>
+      <cd-back-button (backAction)="activeModal.close()"></cd-back-button>
     </div>
   </ng-container>
 </cd-modal>
index 1af872b8d4da097a8a181ce2626fa21c4dc4f1c6..a578f03940273e2f679b0f199b2b82cabe58818a 100644 (file)
@@ -1,5 +1,5 @@
 import { Location } from '@angular/common';
-import { Component, Input } from '@angular/core';
+import { Component, EventEmitter, Input, Output } from '@angular/core';
 
 import { ActionLabelsI18n } from '~/app/shared/constants/app.constants';
 
@@ -9,8 +9,16 @@ import { ActionLabelsI18n } from '~/app/shared/constants/app.constants';
   styleUrls: ['./back-button.component.scss']
 })
 export class BackButtonComponent {
+  @Output() backAction = new EventEmitter();
+  @Input() name: string = this.actionLabels.CANCEL;
+
   constructor(private location: Location, private actionLabels: ActionLabelsI18n) {}
 
-  @Input() name: string = this.actionLabels.CANCEL;
-  @Input() back: Function = () => this.location.back();
+  back() {
+    if (this.backAction.observers.length === 0) {
+      this.location.back();
+    } else {
+      this.backAction.emit();
+    }
+  }
 }
index c7130ef659115f5b31a175f5a9c7077acc0690c1..6d6b5a757398e35c670bbf7864e3429f2115a372 100644 (file)
@@ -16,7 +16,7 @@
                           (submitAction)="onSubmit(confirmationForm.value)">
           {{ buttonText }}
         </cd-submit-button>
-        <cd-back-button [back]="boundCancel"
+        <cd-back-button (backAction)="boundCancel()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index 4d70814547674121bd9420fdca5e89f8ffc93633..06b66265c2c902f568e2c2c01e5fb7ffcdedc770 100644 (file)
@@ -47,7 +47,7 @@
                           (submitAction)="callSubmitAction()">
           <ng-container *ngTemplateOutlet="deletionHeading"></ng-container>
         </cd-submit-button>
-        <cd-back-button [back]="activeModal.close"
+        <cd-back-button (backAction)="activeModal.close()"
                         name="Cancel"
                         i18n-name>
         </cd-back-button>
index f1f4b7f573f6a6ce1f70d2b30a6cea083bef47ea..3efd823cf14e375436693f80d270cf6cf2770842 100755 (executable)
@@ -64,7 +64,7 @@
                           (submitAction)="onSubmitForm(formGroup.value)">
           {{ submitButtonText }}
         </cd-submit-button>
-        <cd-back-button [back]="activeModal.close"></cd-back-button>
+        <cd-back-button (backAction)="activeModal.close()"></cd-back-button>
       </div>
     </form>
   </ng-container>