]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/prometheus: get osd_objectstore once instead twice. 26537/head
authorKonstantin Shalygin <k0ste@k0ste.ru>
Thu, 21 Feb 2019 07:22:21 +0000 (14:22 +0700)
committerKonstantin Shalygin <k0ste@k0ste.ru>
Wed, 27 Feb 2019 03:57:14 +0000 (10:57 +0700)
After merging #25234 & #24821 separetly we get in
get_metadata_and_osd_status() double osd_metadata.get('osd_objectstore') call.

Signed-off-by: Konstantin Shalygin <k0ste@k0ste.ru>
(cherry picked from commit bf3231ba17c7eaada8a24e8cd8a57b8ec6216dc4)

src/pybind/mgr/prometheus/module.py

index c23503f3ba7b5ad25ff32a7fd7421bea2e18db5a..bf6548fb9936d7e7683488974487c55a1440b302 100644 (file)
@@ -498,14 +498,13 @@ class Module(MgrModule):
                     'osd.{}'.format(id_),
                 ))
 
-            osd_objectstore = osd_metadata.get('osd_objectstore', None)
-            if osd_objectstore == "filestore":
+            if obj_store == "filestore":
             # collect filestore backend device
                 osd_dev_node = osd_metadata.get('backend_filestore_dev_node', None)
             # collect filestore journal device
                 osd_wal_dev_node = osd_metadata.get('osd_journal', '')
                 osd_db_dev_node = ''
-            elif osd_objectstore == "bluestore":
+            elif obj_store == "bluestore":
             # collect bluestore backend device
                 osd_dev_node = osd_metadata.get('bluestore_bdev_dev_node', None)
             # collect bluestore wal backend