]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
Merge pull request #13957 from wangzhengyong/import
authorJason Dillaman <dillaman@redhat.com>
Thu, 6 Apr 2017 00:11:33 +0000 (20:11 -0400)
committerGitHub <noreply@github.com>
Thu, 6 Apr 2017 00:11:33 +0000 (20:11 -0400)
rbd: error out if import image format failed

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
1  2 
src/tools/rbd/action/Import.cc

index db0f9e08fd1dffc13b9aa1880342812bb224b816,1217ee500f05c3776f8d0667edb8b32ec876fd55..5367b25a5c094e668bb224677b0c2b3fe00c8733
@@@ -798,10 -748,15 +798,15 @@@ static int do_import(librbd::RBD &rbd, 
    }
  
    if (import_format == 1) {
 -    r = do_import_v1(fd, image, size, imgblklen, pc);
 +    r = do_import_v1(fd, image, size, imgblklen, pc, sparse_size);
    } else {
 -    r = do_import_v2(fd, image, size, imgblklen, pc);
 +    r = do_import_v2(fd, image, size, imgblklen, pc, sparse_size);
    }
+   if (r < 0) {
+     std::cerr << "rbd: failed to import image" << std::endl;
+     image.close();
+     goto err;
+   }
  
    r = image.close();
  err: