pybind/orchestrator/cli: fix OrchestratorError retval sign

OrchestratorError stores errno as abs(), so e.errno is always positive.
Returning retval=e.errno (+22) caused the ceph CLI to exit 0 since it
only propagates the exit code when ret < 0.

Fix by returning retval=-e.errno.

Fixes: https://tracker.ceph.com/issues/75282
Signed-off-by: Nitzan Mordhai <nmordech@redhat.com>

diff --git a/src/pybind/mgr/orchestrator/cli.py b/src/pybind/mgr/orchestrator/cli.py
index 76f57fd37c223ba8d143a747976461bba7c8e86f..4ef3fa58da460f6804f0d7b47f19243b9682a39a 100644 (file)
--- a/src/pybind/mgr/orchestrator/cli.py
+++ b/src/pybind/mgr/orchestrator/cli.py
@@ -18,7 +18,7 @@ class OrchestratorCLICommandBase(CLICommandBase):
                 return func(*args, **kwargs)
             except (OrchestratorError, SpecValidationError) as e:
                 # Do not print Traceback for expected errors.
-                return HandleCommandResult(retval=e.errno, stderr=str(e))
+                return HandleCommandResult(retval=-e.errno, stderr=str(e))
             except ImportError as e:
                 return HandleCommandResult(retval=-errno.ENOENT, stderr=str(e))
             except NotImplementedError: