]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
cmake: do not build DPDK with -march=native
authorNathan Cutler <ncutler@suse.com>
Thu, 2 Aug 2018 18:15:15 +0000 (20:15 +0200)
committerKefu Chai <kchai@redhat.com>
Fri, 17 Aug 2018 06:09:08 +0000 (14:09 +0800)
-march=native causes gcc to use opcodes according to whichever CPU happens to
be installed in the build host, which can be different for every build. This
makes it impossible to achieve a reproducible build.

Also, if the build host has a very new CPU, running the resulting binaries on
older CPUs (of the same family, i.e. x86_64) could result in segmentation
fault.

References: http://tracker.ceph.com/issues/24948
Signed-off-by: Nathan Cutler <ncutler@suse.com>
cmake/modules/Finddpdk.cmake

index aff4b47e050112cc988671d21397c769f9487728..eb5973b81db3808230e8df5fbdff3c56dcf927b8 100644 (file)
@@ -25,8 +25,6 @@ foreach(c ${components})
     set_target_properties(dpdk::${c} PROPERTIES
       INTERFACE_INCLUDE_DIRECTORIES "${DPDK_INCLUDE_DIR}"
       IMPORTED_LOCATION "${DPDK_rte_${c}_LIBRARY}")
-    target_compile_options(dpdk::${c} INTERFACE
-      "-march=native")
     list(APPEND DPDK_LIBRARIES dpdk::${c})
   endif()
 endforeach()