mgr/telemetry: dict.pop() errs on nonexistent key

I suggested this in a review, but failed to correctly understand
what happens when the key doesn't exist.  Test for it.

Signed-off-by: Dan Mick <dan.mick@redhat.com>

diff --git a/src/pybind/mgr/telemetry/module.py b/src/pybind/mgr/telemetry/module.py
index 6065a52cbb805967cb4e54593b65d23502464eb8..e730903ea9fe67af6d32000b8def8d10371691bc 100644 (file)
--- a/src/pybind/mgr/telemetry/module.py
+++ b/src/pybind/mgr/telemetry/module.py
@@ -336,7 +336,8 @@ class Module(MgrModule):
 
             # anonymize the smartctl report itself
             for k in ['serial_number']:
-                m.pop(k)
+                if k in m:
+                    m.pop(k)
 
             res[anon_devid] = m
         return res