]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mon: fix bad return test!
authorGreg Farnum <gregf@hq.newdream.net>
Fri, 5 Mar 2010 01:16:48 +0000 (17:16 -0800)
committerGreg Farnum <gregf@hq.newdream.net>
Fri, 5 Mar 2010 23:46:54 +0000 (15:46 -0800)
cephx_build_service_ticket_blob returns a bool, so it's not ever
going to return <0 -- or if it somehow does that'll be true (good, not false!

src/mon/Monitor.cc

index 79009a591e4e6adb28c8dc8d3c9cb4d4a2f314ad..e20048749e4d80fdce02f2ea6120157244f1edf3 100644 (file)
@@ -997,8 +997,7 @@ bool Monitor::ms_get_authorizer(int dest_type, AuthAuthorizer **authorizer, bool
   }
 
   CephXTicketBlob blob;
-  ret = cephx_build_service_ticket_blob(info, blob);
-  if (ret < 0)
+  if (!cephx_build_service_ticket_blob(info, blob))
     return false;
   bufferlist ticket_data;
   ::encode(blob, ticket_data);