]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
qa/cephfs: don't take parameter cwd in _create_mntpt()
authorRishabh Dave <ridave@redhat.com>
Wed, 10 Mar 2021 04:39:54 +0000 (10:09 +0530)
committerRishabh Dave <ridave@redhat.com>
Wed, 10 Mar 2021 06:34:41 +0000 (12:04 +0530)
Accepting "cwd" as a parameter in _create_mntpt() methods was a mistake
that happened commit 5e71e9b065b690ede5644b12937dfdb9eec93147.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
qa/tasks/cephfs/fuse_mount.py
qa/tasks/cephfs/mount.py
qa/tasks/vstart_runner.py

index 202a69b2ab65d1e93b3c782a6780954f0bbde346..4ced0df23ae505a81e65c8f3c4be9b38b75e4703 100644 (file)
@@ -62,7 +62,7 @@ class FuseMount(CephFSMount):
         log.info("Client client.%s config is %s" % (self.client_id,
                                                     self.client_config))
 
-        self._create_mntpt(cwd=self.test_dir)
+        self._create_mntpt()
 
         retval = self._run_mount_cmd(mntopts, check_status)
         if retval:
index 50cd378fa005f2afce1fd4df9ffe2cb4d69a9d92..a5c0256c9bf2a359391ebbff50de0f86a4c9bdb7 100644 (file)
@@ -175,7 +175,7 @@ class CephFSMount(object):
         self.fs.wait_for_daemons()
         log.info('Ready to start {}...'.format(type(self).__name__))
 
-    def _create_mntpt(self, cwd=None):
+    def _create_mntpt(self):
         stderr = StringIO()
         # Use 0000 mode to prevent undesired modifications to the mountpoint on
         # the local file system.
index f5fed7c00ce33efe239042e8644f04985ba600dc..73480af9c80da7bf943e49ca26cea1a38eb4b0c2 100644 (file)
@@ -707,12 +707,11 @@ class LocalFuseMount(LocalCephFSMount, FuseMount):
         self._mount_cmd_cwd, self._mount_cmd_logger, \
             self._mount_cmd_stdin = None, None, None
 
-    def _create_mntpt(self, cwd=None):
+    def _create_mntpt(self):
         stderr = StringIO()
         script = f'mkdir -p -v {self.hostfs_mntpt}'.split()
         try:
-            self.client_remote.run(args=script, cwd=self.test_dir,
-                                   stderr=stderr)
+            self.client_remote.run(args=script, stderr=stderr)
         except CommandFailedError:
             if 'file exists' not in stderr.getvalue().lower():
                 raise