]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mon/OSDMonitor: clean up 'osd perf' command placement
authorSage Weil <sage@redhat.com>
Wed, 6 Aug 2014 20:39:51 +0000 (13:39 -0700)
committerSage Weil <sage@redhat.com>
Wed, 6 Aug 2014 20:39:51 +0000 (13:39 -0700)
This doesn't need an OSDMap; move it out of that block.

Signed-off-by: Sage Weil <sage@redhat.com>
src/mon/OSDMonitor.cc

index 0f6204a4e59144e65032e3dbd4b561d61b0fbb7b..6047cb15c439594a2c0f924beea162802ebd4c5e 100644 (file)
@@ -2189,12 +2189,23 @@ bool OSDMonitor::preprocess_command(MMonCommand *m)
     else
       rdata.append(ds);
   }
+  else if (prefix == "osd perf") {
+    const PGMap &pgm = mon->pgmon()->pg_map;
+    if (f) {
+      f->open_object_section("osdstats");
+      pgm.dump_osd_perf_stats(f.get());
+      f->close_section();
+      f->flush(ds);
+    } else {
+      pgm.print_osd_perf_stats(&ds);
+    }
+    rdata.append(ds);
+  }
   else if (prefix == "osd dump" ||
           prefix == "osd tree" ||
           prefix == "osd ls" ||
           prefix == "osd getmap" ||
-          prefix == "osd getcrushmap" ||
-          prefix == "osd perf") {
+          prefix == "osd getcrushmap") {
     string val;
 
     epoch_t epoch = 0;
@@ -2267,17 +2278,6 @@ bool OSDMonitor::preprocess_command(MMonCommand *m)
     } else if (prefix == "osd getcrushmap") {
       p->crush->encode(rdata);
       ss << "got crush map from osdmap epoch " << p->get_epoch();
-    } else if (prefix == "osd perf") {
-      const PGMap &pgm = mon->pgmon()->pg_map;
-      if (f) {
-       f->open_object_section("osdstats");
-       pgm.dump_osd_perf_stats(f.get());
-       f->close_section();
-       f->flush(ds);
-      } else {
-       pgm.print_osd_perf_stats(&ds);
-      }
-      rdata.append(ds);
     }
     if (p != &osdmap)
       delete p;