qa/vstart_runner: fix mutiple 'timeout' option conflicting

The 'timeout' option in the environment may will conflict with the
ones in some ceph commands, like:

$ timeout 120 ./bin/ceph daemon mds.b session config 8718 timeout 45

And the old code will also give us incorrect result like:

['adjust-ulimits', 'ceph-coverage', 'timeout', '120', 'ceph', 'fs', 'dump']
will be transfered to:
['adjust-ulimits', 'ceph-coverage', '120', 'ceph', 'fs', 'dump']

The '120' is left behind.

Fixes: https://tracker.ceph.com/issues/44437
Signed-off-by: Xiubo Li <xiubli@redhat.com>

diff --git a/qa/tasks/vstart_runner.py b/qa/tasks/vstart_runner.py
index ccc706b922b64f8a8ac0ae7a86d79f21fc8af804..c673bfd0acb5efbf55b04c319c0bb29373011fc4 100644 (file)
--- a/qa/tasks/vstart_runner.py
+++ b/qa/tasks/vstart_runner.py
@@ -333,7 +333,7 @@ class LocalRemote(object):
 
         # Filter out helper tools that don't exist in a vstart environment
         args = [a for a in args if a not in {
-            'adjust-ulimits', 'ceph-coverage', 'timeout'}]
+            'adjust-ulimits', 'ceph-coverage'}]
 
         # Adjust binary path prefix if given a bare program name
         if "/" not in args[0]: