]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rbd-mirror: cluster watcher doesn't need to resolve pool names
authorJason Dillaman <dillaman@redhat.com>
Mon, 10 Sep 2018 18:12:26 +0000 (14:12 -0400)
committerJason Dillaman <dillaman@redhat.com>
Wed, 12 Sep 2018 01:07:24 +0000 (21:07 -0400)
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
src/tools/rbd_mirror/ClusterWatcher.cc
src/tools/rbd_mirror/ClusterWatcher.h

index e0c06d5ce7fe470f58130dd5c1026e08a8ce70cf..bff1b2304d388f8ca7ce42d8cbcc989c4cab08ea 100644 (file)
@@ -45,8 +45,7 @@ void ClusterWatcher::refresh_pools()
   dout(20) << "enter" << dendl;
 
   PoolPeers pool_peers;
-  PoolNames pool_names;
-  read_pool_peers(&pool_peers, &pool_names);
+  read_pool_peers(&pool_peers);
 
   Mutex::Locker l(m_lock);
   m_pool_peers = pool_peers;
@@ -54,8 +53,7 @@ void ClusterWatcher::refresh_pools()
   // about config changes for existing pools
 }
 
-void ClusterWatcher::read_pool_peers(PoolPeers *pool_peers,
-                                    PoolNames *pool_names)
+void ClusterWatcher::read_pool_peers(PoolPeers *pool_peers)
 {
   int r = m_cluster->wait_for_latest_osdmap();
   if (r < 0) {
@@ -143,7 +141,6 @@ void ClusterWatcher::read_pool_peers(PoolPeers *pool_peers,
     }
 
     pool_peers->insert({pool_id, Peers{configs.begin(), configs.end()}});
-    pool_names->insert(pool_name);
   }
 
   for (auto it = m_service_pools.begin(); it != m_service_pools.end(); ) {
index 7080a1c6a9991bd58027f1e57544fabfea2f3f5f..9941d15c9ca2516227c96716304f5a134b37076f 100644 (file)
@@ -31,7 +31,6 @@ class ClusterWatcher {
 public:
   typedef std::set<PeerSpec> Peers;
   typedef std::map<int64_t, Peers>  PoolPeers;
-  typedef std::set<std::string> PoolNames;
 
   ClusterWatcher(RadosRef cluster, Mutex &lock,
                  ServiceDaemon<librbd::ImageCtx>* service_daemon);
@@ -53,7 +52,7 @@ private:
   ServicePools m_service_pools;
   PoolPeers m_pool_peers;
 
-  void read_pool_peers(PoolPeers *pool_peers, PoolNames *pool_names);
+  void read_pool_peers(PoolPeers *pool_peers);
 };
 
 } // namespace mirror