]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/cephadm: use ==/!= to compare constant literals (F632)
authorMichael Fritch <mfritch@suse.com>
Thu, 28 Jan 2021 18:24:57 +0000 (11:24 -0700)
committerSebastian Wagner <sebastian.wagner@suse.com>
Tue, 23 Feb 2021 09:58:23 +0000 (10:58 +0100)
Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit b40d28ce900fc4eb88be2480ae584c095120a51a)

src/pybind/mgr/cephadm/tests/test_cephadm.py
src/pybind/mgr/tox.ini

index 6aa72b2ac67ebe00079b12a2e6beeb156b8a6610..4979045ae7679bb6cab8eaacdf9b09ad3aa55ea9 100644 (file)
@@ -851,13 +851,13 @@ class TestCephadm(object):
                 with with_host(cephadm_module, 'test', refresh_hosts=False):
                     code, out, err = cephadm_module.check_host('test')
                     # First should succeed.
-                    assert err is ''
+                    assert err == ''
 
                     # On second it should attempt to reuse the connection, where the
                     # connection is "down" so will recreate the connection. The old
                     # code will blow up here triggering the BOOM!
                     code, out, err = cephadm_module.check_host('test')
-                    assert err is ''
+                    assert err == ''
 
     @mock.patch("cephadm.module.CephadmOrchestrator._get_connection")
     @mock.patch("remoto.process.check")
index 972f8e82ecbeb3417dab5e301526c108a56dea76..4a277ce266f65d55a1d627916304f4fa2a058406 100644 (file)
@@ -13,7 +13,6 @@ max-line-length = 100
 ignore =
     E501,
     F401,
-    F632,
     F811,
     F821,
     F841,