]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
common: drop unused variables "bluestore_csum_*_block" in opts 17394/head
authorsongweibin <song.weibin@zte.com.cn>
Thu, 31 Aug 2017 10:45:21 +0000 (18:45 +0800)
committersongweibin <song.weibin@zte.com.cn>
Thu, 31 Aug 2017 10:47:07 +0000 (18:47 +0800)
Signed-off-by: songweibin <song.weibin@zte.com.cn>
src/common/legacy_config_opts.h
src/common/options.cc

index f680d68a92fbc9208da2606396b784da2262845d..e2ab42ff64e7ab6978e10d979c4d4ee489f4a117 100644 (file)
@@ -1035,8 +1035,6 @@ OPTION(bluestore_block_wal_size, OPT_U64) // rocksdb wal
 OPTION(bluestore_block_wal_create, OPT_BOOL)
 OPTION(bluestore_block_preallocate_file, OPT_BOOL) //whether preallocate space if block/db_path/wal_path is file rather that block device.
 OPTION(bluestore_csum_type, OPT_STR) // none|xxhash32|xxhash64|crc32c|crc32c_16|crc32c_8
-OPTION(bluestore_csum_min_block, OPT_U32)
-OPTION(bluestore_csum_max_block, OPT_U32)
 OPTION(bluestore_min_alloc_size, OPT_U32)
 OPTION(bluestore_min_alloc_size_hdd, OPT_U32)
 OPTION(bluestore_min_alloc_size_ssd, OPT_U32)
index 13633d5708383c75226b4c56f843f1f4480b7afe..6dd71be8f64a5c923d692fca5328de0e38d2b62a 100644 (file)
@@ -3223,19 +3223,6 @@ std::vector<Option> get_global_options() {
     .set_description("Default checksum algorithm to use")
     .set_long_description("crc32c, xxhash32, and xxhash64 are available.  The _16 and _8 variants use only a subset of the bits for more compact (but less reliable) checksumming."),
 
-    Option("bluestore_csum_min_block", Option::TYPE_UINT, Option::LEVEL_ADVANCED)
-    .set_default(4096)
-    .set_safe()
-    .set_description("Minimum block size to checksum")
-    .set_long_description("A larger checksum block means less checksum metadata to store, but results in read amplification when doing a read smaller than this size (because the entire block must be read to verify the checksum).")
-    .add_see_also("bluestore_csum_max_block"),
-
-    Option("bluestore_csum_max_block", Option::TYPE_UINT, Option::LEVEL_ADVANCED)
-    .set_default(64_K)
-    .set_safe()
-    .set_description("Maximum block size to checksum")
-    .add_see_also("bluestore_csum_min_block"),
-
     Option("bluestore_min_alloc_size", Option::TYPE_UINT, Option::LEVEL_ADVANCED)
     .set_default(0)
     .add_tag("mkfs")