MDSLogContext: fix typo in MDSLogContextBase and add more comments

Fix typos in MDSLogContextBase's definition and function '::complete',
also add more comments about setting safe_pos.

Signed-off-by: haoyixing <haoyixing@kuaishou.com>

diff --git a/src/mds/MDSContext.cc b/src/mds/MDSContext.cc
index c702d0253f74fbf89296bd11c1ed2d6e2628506c..a17da0a01f0ac6c3b49d0a737c24ea2defdb1d59 100644 (file)
--- a/src/mds/MDSContext.cc
+++ b/src/mds/MDSContext.cc
@@ -119,8 +119,9 @@ void MDSLogContextBase::complete(int r) {
   MDLog *mdlog = get_mds()->mdlog;
   uint64_t safe_pos = write_pos;
   pre_finish(r);
-  // MDSContextBase::complete() free this
+  // MDSIOContext::complete() free this
   MDSIOContextBase::complete(r);
+  // safe_pos must be updated after MDSIOContext::complete() call
   mdlog->set_safe_pos(safe_pos);
 }
 

diff --git a/src/mds/MDSContext.h b/src/mds/MDSContext.h
index d544115b9b51a8811203ba9c6deb361d34bb30ea..319af50d35426edf29de74df10afa77bdd0e86ce 100644 (file)
--- a/src/mds/MDSContext.h
+++ b/src/mds/MDSContext.h
@@ -118,7 +118,7 @@ private:
 /**
  * Completion for an log operation, takes big MDSRank lock
  * before executing finish function. Update log's safe pos
- * after finish functuon return.
+ * after finish function return.
  */
 class MDSLogContextBase : public MDSIOContextBase
 {