]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/prometheus: export zero valued pg state metrics 49787/head
authorAvan Thakkar <athakkar@redhat.com>
Mon, 16 Jan 2023 12:41:06 +0000 (18:11 +0530)
committerAvan Thakkar <athakkar@redhat.com>
Thu, 19 Jan 2023 10:32:11 +0000 (16:02 +0530)
Fixes: https://tracker.ceph.com/issues/58471
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
As per the Prometheus documentation, omitting zero metrics is not a best practice. The metric value for all PG_STATES should be initialized to zero.

(cherry picked from commit 17d1ecc914b2fe6c5d9e8045a999985988c39447)

src/pybind/mgr/prometheus/module.py

index 9074944f0034af8b9ce5d55b9a5d435b84ed7667..d100195b7d995fec3b6bbbe3ff1ac359429bd8e5 100644 (file)
@@ -1064,6 +1064,8 @@ class Module(MgrModule):
 
         for pool in pg_summary['by_pool']:
             num_by_state: DefaultDict[str, int] = defaultdict(int)
+            for state in PG_STATES:
+                num_by_state[state] = 0
 
             for state_name, count in pg_summary['by_pool'][pool].items():
                 for state in state_name.split('+'):