]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph orch add fails when ipv6 address is surrounded by square brackets. 52296/head
authorTeoman ONAY <tonay@ibm.com>
Mon, 3 Jul 2023 14:00:20 +0000 (16:00 +0200)
committerTeoman ONAY <tonay@ibm.com>
Thu, 31 Aug 2023 08:20:09 +0000 (10:20 +0200)
fixes: https://tracker.ceph.com/issues/61885
fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2153448

Signed-off-by: Teoman ONAY <tonay@ibm.com>
src/pybind/mgr/orchestrator/module.py

index a4ca7704f041a9a8055ca2cc4887b0f3b43a9fc5..ffaaa4b0de62571df7ee9907f9db4595c33efb31 100644 (file)
@@ -19,6 +19,7 @@ from ceph.deployment.inventory import Device  # noqa: F401; pylint: disable=unus
 from ceph.deployment.drive_group import DriveGroupSpec, DeviceSelection, OSDMethod
 from ceph.deployment.service_spec import PlacementSpec, ServiceSpec, service_spec_allow_invalid_from_json, TracingSpec
 from ceph.deployment.hostspec import SpecValidationError
+from ceph.deployment.utils import unwrap_ipv6
 from ceph.utils import datetime_now
 
 from mgr_util import to_pretty_timedelta, format_bytes
@@ -466,6 +467,9 @@ class OrchestratorCli(OrchestratorClientMixin, MgrModule,
         if labels and len(labels) == 1:
             labels = labels[0].split(',')
 
+        if addr is not None:
+            addr = unwrap_ipv6(addr)
+
         s = HostSpec(hostname=hostname, addr=addr, labels=labels, status=_status)
 
         return self._apply_misc([s], False, Format.plain)