]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
JournalingObjectStore: remove misleading comments 12528/head
authorLi Wang <li.wang@kylin-cloud.com>
Fri, 16 Dec 2016 06:43:14 +0000 (06:43 +0000)
committerLi Wang <li.wang@kylin-cloud.com>
Fri, 16 Dec 2016 06:43:14 +0000 (06:43 +0000)
Prior to start journal commit, it always needs to wait the ongoing apply
operation to finish, not only needed during journal replay. Between
commit_start() and commit_started(), it always needs to prevent starting
apply, not only needed during journal replay.

Signed-off-by: Li Wang <li.wang@kylin-cloud.com>
src/os/filestore/JournalingObjectStore.cc

index 467991efd2b690bbc194c81df197b576fdfaa1e4..38e8616c18fe6e1f2afdb010f346169cbec146d9 100644 (file)
@@ -119,7 +119,6 @@ uint64_t JournalingObjectStore::ApplyManager::op_apply_start(uint64_t op)
 {
   Mutex::Locker l(apply_lock);
   while (blocked) {
-    // note: this only happens during journal replay
     dout(10) << "op_apply_start blocked, waiting" << dendl;
     blocked_cond.Wait(apply_lock);
   }
@@ -140,7 +139,7 @@ void JournalingObjectStore::ApplyManager::op_apply_finish(uint64_t op)
   --open_ops;
   assert(open_ops >= 0);
 
-  // signal a blocked commit_start (only needed during journal replay)
+  // signal a blocked commit_start
   if (blocked) {
     blocked_cond.Signal();
   }