]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
osd/osd_types: reset payload_len in merge_osd_op_vector_out_data
authorSage Weil <sage@redhat.com>
Tue, 24 Sep 2019 19:28:01 +0000 (14:28 -0500)
committerSage Weil <sage@redhat.com>
Wed, 25 Sep 2019 16:06:10 +0000 (11:06 -0500)
This is cleaner and simpler.

Signed-off-by: Sage Weil <sage@redhat.com>
src/messages/MOSDOpReply.h
src/osd/osd_types.cc

index 657f7403635860c973b681a889bbd12e2fcf9b3a..c5ada193dcb1e84770e600f67b76d5348becd1ff 100644 (file)
@@ -147,7 +147,6 @@ public:
 
     // zero out ops payload_len and possibly out data
     for (unsigned i = 0; i < ops.size(); i++) {
-      ops[i].op.payload_len = 0;
       if (ignore_out_data &&
          (ceph_osd_op_mode_modify(ops[i].op.op) ||
           ceph_osd_op_mode_cache(ops[i].op.op))) {
index 69e8157a92349c5a4da48d1c8750dc12327074de..cd7014757b96bda4ff90a6edc936817f0b4b1867 100644 (file)
@@ -6716,8 +6716,8 @@ void OSDOp::split_osd_op_vector_out_data(vector<OSDOp>& ops, ceph::buffer::list&
 void OSDOp::merge_osd_op_vector_out_data(vector<OSDOp>& ops, ceph::buffer::list& out)
 {
   for (unsigned i = 0; i < ops.size(); i++) {
+    ops[i].op.payload_len = ops[i].outdata.length();
     if (ops[i].outdata.length()) {
-      ops[i].op.payload_len = ops[i].outdata.length();
       out.append(ops[i].outdata);
     }
   }