ceph-disk: reimplement is_partition

Previously we were assuming any device that ended in a digit was a
partition, but this is not at all correct (e.g., /dev/sr0, /dev/rbd1).
Instead, look in /dev/disk/by-id and see if there is a symlink that ends in
-partNN that links to our device.

There is probably still a better way...

Signed-off-by: Sage Weil <sage@inktank.com>

diff --git a/src/ceph-disk b/src/ceph-disk
index c285c28b99e09b392bfb9b08e53445ac1a000983..bce09e0ccd9d753a3860913e45b085aa49452599 100755 (executable)
--- a/src/ceph-disk
+++ b/src/ceph-disk
@@ -180,9 +180,22 @@ def is_partition(dev):
     if not stat.S_ISBLK(os.lstat(dev).st_mode):
         raise Error('not a block device', dev)
 
-    # if the device ends in a number, it is a partition (e.g., /dev/sda3)
-    if dev[-1].isdigit():
-        return True
+    # we can't tell just from the name of the device if it is a
+    # partition or not.  look in the by-path dir and see if the
+    # referring symlink ends in -partNNN.
+    name = dev.split('/')[-1]
+    for name in os.listdir('/dev/disk/by-path'):
+        target = os.readlink(os.path.join('/dev/disk/by-path', name))
+        cdev = target.split('/')[-1]
+        if '/dev/' + cdev != dev:
+            continue
+        (baser) = re.search('(.*)-part\d+$', name)
+        if baser is not None:
+            return True
+        else:
+            return False
+
+    # hrm, don't know...
     return False