]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/rook: OSD create: Fix broken list-comprehension
authorSebastian Wagner <sebastian.wagner@suse.com>
Tue, 23 Feb 2021 10:01:52 +0000 (11:01 +0100)
committerSebastian Wagner <sewagner@redhat.com>
Wed, 9 Jun 2021 10:39:58 +0000 (12:39 +0200)
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
src/pybind/mgr/rook/rook_cluster.py

index 4fd660430364179cdd6fc3c4fbb704e87cd744e8..daf3c8667b71639104a08365d662edd5625dacaf 100644 (file)
@@ -592,7 +592,8 @@ class RookCluster(object):
                         if block_devices:
                             if not hasattr(current_node, 'devices'):
                                 current_node.devices = ccl.DevicesList()
-                            new_devices = list(set(block_devices) - set([d.name for d in current_node.devices]))
+                            current_device_names = set(d.name for d in current_node.devices)
+                            new_devices = [bd for bd in block_devices if bd.path not in current_device_names]
                             current_node.devices.extend(
                                 ccl.DevicesItem(name=n.path) for n in new_devices
                             )