]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
osd: min_pg_log_entries == max == pg_log_dups_tracked 20394/head
authorSage Weil <sage@redhat.com>
Fri, 9 Feb 2018 22:36:35 +0000 (16:36 -0600)
committerSage Weil <sage@redhat.com>
Fri, 9 Feb 2018 22:36:35 +0000 (16:36 -0600)
- avoid a memory utilization explosion when a pg is degraded
- avoid overhead of converting pg log entries to dup op entries.

The net of this is that during recovery we will keep fewer entries, which
means we will trigger backfill sooner rather than later.

In the future, it would still be nice to dynamically adjust this in such
a way as to avoid increasing the memory footprint (e.g., by borrowing
memory from BlueStore).

Signed-off-by: Sage Weil <sage@redhat.com>
src/common/options.cc

index fd213b483bf3ba9e3bc31d9b0645951072f21d07..81a8f2f2d87fcb2a9619ca5abaa1fcd2cfbfc106 100644 (file)
@@ -2837,14 +2837,14 @@ std::vector<Option> get_global_options() {
     .set_description(""),
 
     Option("osd_min_pg_log_entries", Option::TYPE_UINT, Option::LEVEL_ADVANCED)
-    .set_default(1500)
+    .set_default(3000)
     .set_description("minimum number of entries to maintain in the PG log")
     .add_service("osd")
     .add_see_also("osd_max_pg_log_entries")
     .add_see_also("osd_pg_log_dups_tracked"),
 
     Option("osd_max_pg_log_entries", Option::TYPE_UINT, Option::LEVEL_ADVANCED)
-    .set_default(10000)
+    .set_default(3000)
     .set_description("maximum number of entries to maintain in the PG log when degraded before we trim")
     .add_service("osd")
     .add_see_also("osd_min_pg_log_entries")