]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/mgr_util: don't set event when it is already set
authorRishabh Dave <ridave@redhat.com>
Thu, 26 Sep 2024 19:11:25 +0000 (00:41 +0530)
committerRishabh Dave <ridave@redhat.com>
Thu, 26 Sep 2024 19:23:45 +0000 (00:53 +0530)
In class RTimer in mgr_util.py, "self.finished.set()" is run even though
the event self.finished was set just now. If it wasn't set, the while
loop the precedes it would've never finished running. Therefore, remove
this redundant line of code.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
src/pybind/mgr/mgr_util.py

index 67246545eea0f8d4638d4e2455d0fc1bf45f4dcd..a999b6525e9f1ee24e32d4b5d47a7b7b24772c65 100644 (file)
@@ -88,7 +88,6 @@ class RTimer(Timer):
             while not self.finished.is_set():
                 self.finished.wait(self.interval)
                 self.function(*self.args, **self.kwargs)
-            self.finished.set()
         except Exception as e:
             logger.error("task exception: %s", e)
             raise