]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
cmake: fix lz4 params when building rocksdb 36307/head
authorLucian Petrut <lpetrut@cloudbasesolutions.com>
Mon, 27 Jul 2020 13:57:59 +0000 (13:57 +0000)
committerLucian Petrut <lpetrut@cloudbasesolutions.com>
Mon, 27 Jul 2020 16:05:09 +0000 (16:05 +0000)
Recent RocksDB version use slightly different parameter names for
the LZ4 include/lib dirs, we'll have to pass the right ones.

We'll also have to fix the "CMAKE_TOOLCHAIN_FILE" parameter,
which isn't passed properly.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
cmake/modules/BuildRocksDB.cmake

index de9748878b7c31c193a1678901d7ff469272f3fa..28559ea1cb329967f3e027bf4d7710cfd07a4197 100644 (file)
@@ -8,7 +8,7 @@ function(build_rocksdb)
   list(APPEND rocksdb_CMAKE_ARGS -DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH_ALT_SEP})
   if(CMAKE_TOOLCHAIN_FILE)
     list(APPEND rocksdb_CMAKE_ARGS
-         -DCMAKE_TOOLCHAIN_FILE=$CMAKE_TOOLCHAIN_FILE)
+         -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE})
   endif()
 
   if(ALLOCATOR STREQUAL "jemalloc")
@@ -35,8 +35,8 @@ function(build_rocksdb)
   if(LZ4_FOUND)
     list(APPEND rocksdb_INTERFACE_LINK_LIBRARIES LZ4::LZ4)
     # When cross compiling, cmake may fail to locate lz4.
-    list(APPEND rocksdb_CMAKE_ARGS -DLZ4_INCLUDE_DIR=${LZ4_INCLUDE_DIR})
-    list(APPEND rocksdb_CMAKE_ARGS -DLZ4_LIBRARIES=${LZ4_LIBRARY})
+    list(APPEND rocksdb_CMAKE_ARGS -Dlz4_INCLUDE_DIRS=${LZ4_INCLUDE_DIR})
+    list(APPEND rocksdb_CMAKE_ARGS -Dlz4_LIBRARIES=${LZ4_LIBRARY})
   endif()
 
   list(APPEND rocksdb_CMAKE_ARGS -DWITH_ZLIB=${ZLIB_FOUND})