]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
qa/rgw: fix user cleanup in s3tests task
authorCasey Bodley <cbodley@redhat.com>
Thu, 30 Jan 2025 17:31:35 +0000 (12:31 -0500)
committerCasey Bodley <cbodley@redhat.com>
Wed, 26 Feb 2025 19:54:26 +0000 (14:54 -0500)
the if condition was backwards, preventing non-keystone users from being
removed after the s3tests task runs

Fixes: https://tracker.ceph.com/issues/69741
Signed-off-by: Casey Bodley <cbodley@redhat.com>
qa/tasks/s3tests.py

index 85ab97d23cd26c31e02a6204d82954d872042c0d..383f4736302fb051cd2d476e5954cd4ce806f8ac 100644 (file)
@@ -251,7 +251,7 @@ def create_users(ctx, config, s3tests_conf):
         for client in config.keys():
             for section, user in users.items():
                 # don't need to delete keystone users
-                if not user in keystone_users:
+                if section in keystone_users:
                     continue
                 uid = '{user}.{client}'.format(user=user, client=client)
                 cluster_name, daemon_type, client_id = teuthology.split_role(client)