mgr/cephadm: sanity check upgrade version

Signed-off-by: Sage Weil <sage@redhat.com>

diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py
index 8cc007e6b176abaab87b38056474070ac61981b9..d86d01556fcca94e50ec8b945ac47b4ac796cebb 100644 (file)
--- a/src/pybind/mgr/cephadm/module.py
+++ b/src/pybind/mgr/cephadm/module.py
@@ -2789,6 +2789,14 @@ receivers:
             raise OrchestratorError('upgrade is not supported in %s mode' % (
                 self.mode))
         if version:
+            try:
+                (major, minor, patch) = version.split('.')
+                assert int(minor) >= 0
+                assert int(patch) >= 0
+            except:
+                raise OrchestratorError('version must be in the form X.Y.Z (e.g., 15.2.3)')
+            if int(major) < 15 or (int(major) == 15 and int(minor) < 2):
+                raise OrchestratorError('cephadm only supports octopus (15.2.0) or later')
             target_name = self.container_image_base + ':v' + version
         elif image:
             target_name = image