src/cephadm: added ceph-exporter to post-rotate signal list

As the title says this change simply adds ceph-exporter to a logrotate
list which will ensure ceph-exporter will continue writing to a new log
file even after log rotation. Currently no new log file will be written to
and you will have to manually add ceph-exporter to logrotate.d.

Signed-off-by: Timothy Q Nguyen <timqn22@gmail.com>

diff --git a/src/cephadm/cephadmlib/logging.py b/src/cephadm/cephadmlib/logging.py
index f5893d3a51d1fe77ae4610ca13bafaa9e91b9a89..f722a33e78dff950c313ce2d94c842cad5e4b05c 100644 (file)
--- a/src/cephadm/cephadmlib/logging.py
+++ b/src/cephadm/cephadmlib/logging.py
@@ -255,6 +255,7 @@ def write_cluster_logrotate_config(ctx: CephadmContext, fsid: str) -> None:
         should be harmless.
         """
         targets: List[str] = [
+            'ceph-exporter',
             'ceph-mon',
             'ceph-mgr',
             'ceph-mds',

diff --git a/src/cephadm/tests/test_logrotate_config.py b/src/cephadm/tests/test_logrotate_config.py
index c97f21019d8682197cfd5bb0a98147addb62e904..2f69046cab1d38130718e7d2e16d6a4d72b42fb2 100644 (file)
--- a/src/cephadm/tests/test_logrotate_config.py
+++ b/src/cephadm/tests/test_logrotate_config.py
@@ -23,7 +23,7 @@ def test_cluster_logrotate_config(cephadm_fs):
     compress
     sharedscripts
     postrotate
-        killall -q -1 ceph-mon ceph-mgr ceph-mds ceph-osd ceph-fuse radosgw rbd-mirror cephfs-mirror tcmu-runner || pkill -1 -x 'ceph-mon|ceph-mgr|ceph-mds|ceph-osd|ceph-fuse|radosgw|rbd-mirror|cephfs-mirror|tcmu-runner' || true
+        killall -q -1 ceph-exporter ceph-mon ceph-mgr ceph-mds ceph-osd ceph-fuse radosgw rbd-mirror cephfs-mirror tcmu-runner || pkill -1 -x 'ceph-exporter|ceph-mon|ceph-mgr|ceph-mds|ceph-osd|ceph-fuse|radosgw|rbd-mirror|cephfs-mirror|tcmu-runner' || true
     endscript
     missingok
     notifempty