]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/cephadm: fix removing offline hosts with ingress daemons 49850/head
authorAdam King <adking@redhat.com>
Sun, 22 Jan 2023 18:59:51 +0000 (13:59 -0500)
committerAdam King <adking@redhat.com>
Wed, 25 Jan 2023 00:05:36 +0000 (19:05 -0500)
We need to convert the daemon type to service type here
or we'll try to access the "haproxy" or "keepalived" index
of the cephadm_services dictionary, which doesn't have those
keys (but does have an "ingress" key)

Fixes: https://tracker.ceph.com/issues/58537
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit d9624e066610e7c924b20d8fd8d99a84bf0eea84)

src/pybind/mgr/cephadm/module.py

index 178abd985d106894531f5263c5ba08560b94ec56..6e6772385456d996465cbd2bfdd326e2fb1e3aca 100644 (file)
@@ -1510,8 +1510,8 @@ Then run the following:
                 self.log.info(f"removing: {d.name()}")
 
                 if d.daemon_type != 'osd':
-                    self.cephadm_services[str(d.daemon_type)].pre_remove(d)
-                    self.cephadm_services[str(d.daemon_type)].post_remove(d, is_failed_deploy=False)
+                    self.cephadm_services[daemon_type_to_service(str(d.daemon_type))].pre_remove(d)
+                    self.cephadm_services[daemon_type_to_service(str(d.daemon_type))].post_remove(d, is_failed_deploy=False)
                 else:
                     cmd_args = {
                         'prefix': 'osd purge-actual',