]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd: rename PG::rep_repair_primary_object() to repair_object()
authorKefu Chai <kchai@redhat.com>
Sun, 7 Feb 2021 04:24:21 +0000 (12:24 +0800)
committerKefu Chai <kchai@redhat.com>
Tue, 9 Feb 2021 03:38:22 +0000 (11:38 +0800)
as we should expose the internals using the name of interface, and there
is no need to differentiate rep_repair_primary_object() from another
repair method.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/osd/pg.cc
src/crimson/osd/pg.h

index 353db16da5674abeab814a1559a40d88bb9317e0..145293565b3800d74a113e7d32f36cbb3ce90569 100644 (file)
@@ -683,11 +683,12 @@ seastar::future<Ref<MOSDOpReply>> PG::handle_failed_op(
   }, load_obc_ertr::assert_all{ "can't live with object state messed up" });
 }
 
-seastar::future<> PG::rep_repair_primary_object(
+seastar::future<> PG::repair_object(
   Ref<MOSDOp> m,
   const hobject_t& oid,
   eversion_t& v) 
 {
+  // see also PrimaryLogPG::rep_repair_primary_object()
   assert(is_primary());
   logger().debug("{}: {} peers osd.{}", __func__, oid, get_acting_recovery_backfill());
   // Add object to PG's missing set if it isn't there already
@@ -777,7 +778,7 @@ PG::do_osd_ops(
   }, crimson::ct_error::object_corrupted::handle([m,
                                      obc,
                                      this] () {
-    return rep_repair_primary_object(m, obc->obs.oi.soid, obc->obs.oi.version).then([]() -> PG::do_osd_ops_ertr::future<Ref<MOSDOpReply>> {
+    return repair_object(m, obc->obs.oi.soid, obc->obs.oi.version).then([]() -> PG::do_osd_ops_ertr::future<Ref<MOSDOpReply>> {
       return crimson::ct_error::eagain::make();
     });
   }), OpsExecuter::osd_op_errorator::all_same_way([ox = std::move(ox),
index 4fa5c27380c7b8eb95d099b209a052da4c1fe41b..38fb3613aecca90fa2c7a6cc9eeeb61dad3d6e2b 100644 (file)
@@ -539,7 +539,7 @@ private:
                                       ObjectContextRef&& obc,
                                       ceph::os::Transaction&& txn,
                                       const osd_op_params_t& oop);
-  seastar::future<> rep_repair_primary_object(Ref<MOSDOp> m, 
+  seastar::future<> repair_object(Ref<MOSDOp> m,
                const hobject_t& oid,
                eversion_t& v);