tools: move po::collect_unrecognized in the try block

Signed-off-by: Loic Dachary <loic-201408@dachary.org>

diff --git a/src/tools/ceph_monstore_tool.cc b/src/tools/ceph_monstore_tool.cc
index 547f86d96ac9a2298faa701a9683513b4420d050..aa96251c182b2de731e8e7dad1eeb9b7a289c2d9 100644 (file)
--- a/src/tools/ceph_monstore_tool.cc
+++ b/src/tools/ceph_monstore_tool.cc
@@ -133,6 +133,7 @@ int main(int argc, char **argv) {
   p.add("command", 1);
   p.add("version", 1);
 
+  vector<string> ceph_option_strings;
   po::variables_map vm;
   try {
   po::parsed_options parsed =
@@ -141,14 +142,15 @@ int main(int argc, char **argv) {
     parsed,
     vm);
     po::notify(vm);
+
+  ceph_option_strings = po::collect_unrecognized(parsed.options,
+                                                po::include_positional);
   } catch(po::error &e) {
     std::cerr << e.what() << std::endl;
     return 1;
   }
 
   vector<const char *> ceph_options, def_args;
-  vector<string> ceph_option_strings = po::collect_unrecognized(
-    parsed.options, po::include_positional);
   ceph_options.reserve(ceph_option_strings.size());
   for (vector<string>::iterator i = ceph_option_strings.begin();
        i != ceph_option_strings.end();

diff --git a/src/tools/ceph_objectstore_tool.cc b/src/tools/ceph_objectstore_tool.cc
index 3d09f6e81f39745aa8af005af302b0159b42072f..6ec8582edfbcfb82c2ac58a1adef7a029b8c7f0c 100644 (file)
--- a/src/tools/ceph_objectstore_tool.cc
+++ b/src/tools/ceph_objectstore_tool.cc
@@ -1837,12 +1837,15 @@ int main(int argc, char **argv)
   po::positional_options_description pd;
   pd.add("object", 1).add("objcmd", 1).add("arg1", 1).add("arg2", 1);
 
+  vector<string> ceph_option_strings;
   po::variables_map vm;
   try {
   po::parsed_options parsed =
    po::command_line_parser(argc, argv).options(all).allow_unregistered().positional(pd).run();
   po::store( parsed, vm);
     po::notify(vm);
+    ceph_option_strings = po::collect_unrecognized(parsed.options,
+                                                  po::include_positional);
   } catch(po::error &e) {
     std::cerr << e.what() << std::endl;
     return 1;
@@ -1981,8 +1984,6 @@ int main(int argc, char **argv)
 
   vector<const char *> ceph_options;
   env_to_vec(ceph_options);
-  vector<string> ceph_option_strings = po::collect_unrecognized(
-    parsed.options, po::include_positional);
   ceph_options.reserve(ceph_options.size() + ceph_option_strings.size());
   for (vector<string>::iterator i = ceph_option_strings.begin();
        i != ceph_option_strings.end();

diff --git a/src/tools/ceph_osdomap_tool.cc b/src/tools/ceph_osdomap_tool.cc
index 191cb08983ee959309585c7ce7eeea50d22ea61d..f4790bb29b8caed881d85c9cb2ad7a3dc8b18e37 100644 (file)
--- a/src/tools/ceph_osdomap_tool.cc
+++ b/src/tools/ceph_osdomap_tool.cc
@@ -41,6 +41,7 @@ int main(int argc, char **argv) {
   po::positional_options_description p;
   p.add("command", 1);
 
+  vector<string> ceph_option_strings;
   po::variables_map vm;
   try {
   po::parsed_options parsed =
@@ -49,14 +50,15 @@ int main(int argc, char **argv) {
     parsed,
     vm);
     po::notify(vm);
+
+  ceph_option_strings = po::collect_unrecognized(parsed.options,
+                                                po::include_positional);
   } catch(po::error &e) {
     std::cerr << e.what() << std::endl;
     return 1;
   }
 
   vector<const char *> ceph_options, def_args;
-  vector<string> ceph_option_strings = po::collect_unrecognized(
-    parsed.options, po::include_positional);
   ceph_options.reserve(ceph_option_strings.size());
   for (vector<string>::iterator i = ceph_option_strings.begin();
        i != ceph_option_strings.end();