librbd: Initialization of class member variables

Fixes the coverity issues:

** 1402627 Uninitialized scalar field
CID 1402627 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member promotion_state is not
initialized in this constructor nor in any functions that it calls.

** 1402630 Uninitialized scalar field
CID 1402630 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member m_promotion_state is not
initialized in this constructor nor in any functions that it calls.

** 1402631 Uninitialized scalar field
CID 1402631 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member m_promotion_state is not
initialized in this constructor nor in any functions that it calls.

** 1402632 Uninitialized scalar field
CID 1402632 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member tag_tid is not initialized
in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar <amitkuma@redhat.com>

diff --git a/src/librbd/Journal.cc b/src/librbd/Journal.cc
index 37e84d7d421db7db4bea701fe09de9f8f50ae38e..c7b5e11f69297d6be62b0b42cdded5a517ee4f64 100644 (file)
--- a/src/librbd/Journal.cc
+++ b/src/librbd/Journal.cc
@@ -104,7 +104,7 @@ struct C_GetTagOwner : public Context {
   Journaler journaler;
   cls::journal::Client client;
   journal::ImageClientMeta client_meta;
-  uint64_t tag_tid;
+  uint64_t tag_tid = 0;
   journal::TagData tag_data;
 
   C_GetTagOwner(librados::IoCtx &io_ctx, const std::string &image_id,

diff --git a/src/librbd/api/Mirror.cc b/src/librbd/api/Mirror.cc
index 25ffea03e8c05f3315b4420726eb1d9f8a452823..560cfde5f263c4d8e1dbb7f54dbb7a2e1c703cb5 100644 (file)
--- a/src/librbd/api/Mirror.cc
+++ b/src/librbd/api/Mirror.cc
@@ -82,7 +82,7 @@ struct C_ImageGetInfo : public Context {
   Context *on_finish;
 
   cls::rbd::MirrorImage mirror_image;
-  mirror::PromotionState promotion_state;
+  mirror::PromotionState promotion_state = mirror::PROMOTION_STATE_PRIMARY;
 
   C_ImageGetInfo(mirror_image_info_t *mirror_image_info, Context *on_finish)
     : mirror_image_info(mirror_image_info), on_finish(on_finish) {

diff --git a/src/librbd/mirror/DemoteRequest.h b/src/librbd/mirror/DemoteRequest.h
index a4f6f0c0964686fcc18fd56d000f63d433c485b6..7dc0585e056c5ea10cb969edd7e32e2c9809feb3 100644 (file)
--- a/src/librbd/mirror/DemoteRequest.h
+++ b/src/librbd/mirror/DemoteRequest.h
@@ -59,7 +59,7 @@ private:
   bool m_blocked_requests = false;
 
   cls::rbd::MirrorImage m_mirror_image;
-  PromotionState m_promotion_state;
+  PromotionState m_promotion_state = PROMOTION_STATE_PRIMARY;
 
   void get_info();
   void handle_get_info(int r);

diff --git a/src/librbd/mirror/PromoteRequest.h b/src/librbd/mirror/PromoteRequest.h
index 185dc22b0ed5c85d437e99798e1040a6fac78667..17609c5ff8cafdfed24297dff54e69b919a7ea42 100644 (file)
--- a/src/librbd/mirror/PromoteRequest.h
+++ b/src/librbd/mirror/PromoteRequest.h
@@ -55,7 +55,7 @@ private:
   Context *m_on_finish;
 
   cls::rbd::MirrorImage m_mirror_image;
-  PromotionState m_promotion_state;
+  PromotionState m_promotion_state = PROMOTION_STATE_PRIMARY;
 
   void get_info();
   void handle_get_info(int r);