]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw: rados service shuts down rados client on shutdown()
authorCasey Bodley <cbodley@redhat.com>
Sun, 11 Sep 2022 22:13:52 +0000 (18:13 -0400)
committerCasey Bodley <cbodley@redhat.com>
Mon, 3 Oct 2022 17:24:48 +0000 (13:24 -0400)
if we leave the rados client running, it will keep delivering
AioCompletions while we're shutting other things down

this resolves a valgrind use-after-free where rgw::notify::Manager
gets completions after its destruction

Signed-off-by: Casey Bodley <cbodley@redhat.com>
src/rgw/services/svc_rados.cc

index 1617a2ec6c611ffcc78d620b1aff416d5404b256..388f0b05cfc511b99c747740968cce7d9093d4fd 100644 (file)
@@ -45,6 +45,7 @@ void RGWSI_RADOS::shutdown()
   if (async_processor) {
     async_processor->stop();
   }
+  rados.shutdown();
 }
 
 void RGWSI_RADOS::stop_processor()