secret: close fd on error

CID 717079: Resource leak (RESOURCE_LEAK)
At (6): Handle variable "fd" going out of scope leaks the handle.

Signed-off-by: Josh Durgin <josh.durgin@inktank.com>

diff --git a/src/common/secret.c b/src/common/secret.c
index 0d2cfb61e379fa455ed7195153cd6ad97e7db770..f37619a72dad29a296822ba880bcdc67e962febf 100644 (file)
--- a/src/common/secret.c
+++ b/src/common/secret.c
@@ -38,6 +38,7 @@ int read_secret_from_file(const char *filename, char *secret, size_t max_len)
   len = safe_read(fd, secret, max_len);
   if (len <= 0) {
     perror("unable to read secret from file");
+    close(fd);
     return -1;
   }
   end = secret;