Added comment explaining the change

Signed-off-by: Paul Reece <paul@reece.cc>

diff --git a/src/rgw/rgw_multi.cc b/src/rgw/rgw_multi.cc
index 82c5d0ed2cd97a2454f6da88ae8308df691df811..e2f69ac60a7d4b66a8d7666847fe700907228df3 100644 (file)
--- a/src/rgw/rgw_multi.cc
+++ b/src/rgw/rgw_multi.cc
@@ -56,6 +56,7 @@ bool RGWMultiCompleteUpload::xml_end(const char *el) {
 
 XMLObj *RGWMultiXMLParser::alloc_obj(const char *el) {
   XMLObj *obj = NULL;
+  // CompletedMultipartUpload is incorrect but some versions of some libraries use it, see PR #41700
   if (strcmp(el, "CompleteMultipartUpload") == 0 ||
       strcmp(el, "CompletedMultipartUpload") == 0 ||
       strcmp(el, "MultipartUpload") == 0) {

diff --git a/src/rgw/rgw_op.cc b/src/rgw/rgw_op.cc
index 5e6f13aed0996fe6f4183ff89f554c0d4008c0a8..2370213e2f3944de63e5bf78d148b9b9a8aa16ce 100644 (file)
--- a/src/rgw/rgw_op.cc
+++ b/src/rgw/rgw_op.cc
@@ -5888,6 +5888,7 @@ void RGWCompleteMultipart::execute(optional_yield y)
 
   parts = static_cast<RGWMultiCompleteUpload *>(parser.find_first("CompleteMultipartUpload"));
   if (!parts || parts->parts.empty()) {
+    // CompletedMultipartUpload is incorrect but some versions of some libraries use it, see PR #41700
     parts = static_cast<RGWMultiCompleteUpload *>(parser.find_first("CompletedMultipartUpload"));
   }