]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mds: func name fixup, plus, and additional log message 54958/head
authorVenky Shankar <vshankar@redhat.com>
Tue, 19 Dec 2023 05:19:39 +0000 (00:19 -0500)
committerVenky Shankar <vshankar@redhat.com>
Tue, 19 Dec 2023 05:21:46 +0000 (00:21 -0500)
... when tid isn't found in pending_notifies.

Found this by code reading when trying to RCA

        https://tracker.ceph.com/issues/54741

Signed-off-by: Venky Shankar <vshankar@redhat.com>
src/mds/MDSTableServer.cc

index 5514f1e784784909e5e7fa0dbbb64cdf2dbe00b7..c5cb0b817e02421ba967fe02b3ebbe8f0ce8c965 100644 (file)
@@ -71,7 +71,7 @@ void MDSTableServer::handle_prepare(const cref_t<MMDSTableRequest> &req)
 
 void MDSTableServer::_prepare_logged(const cref_t<MMDSTableRequest> &req, version_t tid)
 {
-  dout(7) << "_create_logged " << *req << " tid " << tid << dendl;
+  dout(7) << __func__ << ": req=" << *req << " tid " << tid << dendl;
   mds_rank_t from = mds_rank_t(req->get_source().num());
 
   ceph_assert(g_conf()->mds_kill_mdstable_at != 2);
@@ -114,6 +114,8 @@ void MDSTableServer::handle_notify_ack(const cref_t<MMDSTableRequest> &m)
       dout(0) << "got unexpected notify ack for tid " <<  tid << " from mds." << from << dendl;
     }
   } else {
+    dout(0) << __func__ << ": tid=" << tid << " from mds." << from
+           << " not tracked in pending notifies" << dendl;
   }
 }