]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
ReplicatedPG: don't bless C_OSD_SendMessageOnConn 669/head
authorSamuel Just <sam.just@inktank.com>
Tue, 1 Oct 2013 19:22:00 +0000 (12:22 -0700)
committerSamuel Just <sam.just@inktank.com>
Tue, 1 Oct 2013 19:22:02 +0000 (12:22 -0700)
C_OSD_SendMessageOnConn doesn't need to lock the pg.
Canceling it resulted in a leaked message.

Fixes: 6443
Signed-off-by: Samuel Just <sam.just@inktank.com>
src/osd/ReplicatedPG.cc

index fcaca434ba895ddbc9267ba2628007bc7d0a8f17..a661aa7f786f09e53feed50a4a1c2b8278b39a91 100644 (file)
@@ -1602,9 +1602,8 @@ void ReplicatedBackend::_do_push(OpRequestRef op)
   reply->compute_cost(cct);
 
   t->register_on_complete(
-    get_parent()->bless_context(
-      new C_OSD_SendMessageOnConn(
-       osd, reply, m->get_connection())));
+    new C_OSD_SendMessageOnConn(
+      osd, reply, m->get_connection()));
 
   get_parent()->queue_transaction(t);
 }
@@ -1670,9 +1669,8 @@ void ReplicatedBackend::_do_pull_response(OpRequestRef op)
     reply->compute_cost(cct);
 
     t->register_on_complete(
-      get_parent()->bless_context(
-       new C_OSD_SendMessageOnConn(
-         osd, reply, m->get_connection())));
+      new C_OSD_SendMessageOnConn(
+       osd, reply, m->get_connection()));
   }
 
   get_parent()->queue_transaction(t);