]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/rbd_support: remove CreateSnapshotRequests __del__() 54293/head
authorRamana Raja <rraja@redhat.com>
Mon, 30 Oct 2023 15:05:27 +0000 (11:05 -0400)
committerRamana Raja <rraja@redhat.com>
Mon, 6 Nov 2023 16:41:15 +0000 (11:41 -0500)
There is no need for CreateSnapshotRequests.__del__() that calls
CreateSnapshotRequests.wait_for_pending().
MirrorSnapshotScheduleHandler.shutdown() already calls
CreateSnapshotRequests.wait_for_pending().

Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit fed1e87685a698876cf167b3681327e5b0066ee6)

Conflicts:
       src/pybind/mgr/rbd_support/mirror_snapshot_schedule.py
 - Above conflict was due to commit e4a16e2
   ("mgr/rbd_support: add type annotation") not in pacific

src/pybind/mgr/rbd_support/mirror_snapshot_schedule.py

index 69a8f677f862aa621a20a26080a45634f0ef14db..a8b56b165cb846710145ccdf19783ffc96d5a0c1 100644 (file)
@@ -35,9 +35,6 @@ class CreateSnapshotRequests:
         self.queue = []
         self.ioctxs = {}
 
-    def __del__(self):
-        self.wait_for_pending()
-
     def wait_for_pending(self):
         with self.lock:
             while self.pending: