mds: mark print methods const

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

diff --git a/src/mds/BatchOp.h b/src/mds/BatchOp.h
index bc4e21bcea9591a2fba1433062b604c5f350093a..5277c3d69f8d7bd8df0c15e654283ab319e63817 100644 (file)
--- a/src/mds/BatchOp.h
+++ b/src/mds/BatchOp.h
@@ -27,7 +27,7 @@ public:
   virtual void add_request(const ceph::ref_t<class MDRequestImpl>& mdr) = 0;
   virtual ceph::ref_t<class MDRequestImpl> find_new_head() = 0;
 
-  virtual void print(std::ostream&) = 0;
+  virtual void print(std::ostream&) const = 0;
 
   void forward(mds_rank_t target);
   void respond(int r);

diff --git a/src/mds/CDentry.cc b/src/mds/CDentry.cc
index 6f20f53d144da61e3a95fb81384e5655f64bbab4..0b83d34afcd10251fd40b901a3bdeaa255157596 100644 (file)
--- a/src/mds/CDentry.cc
+++ b/src/mds/CDentry.cc
@@ -33,7 +33,7 @@
 
 using namespace std;
 
-ostream& CDentry::print_db_line_prefix(ostream& out)
+ostream& CDentry::print_db_line_prefix(ostream& out) const
 {
   return out << ceph_clock_now() << " mds." << dir->mdcache->mds->get_nodeid() << ".cache.den(" << dir->ino() << " " << name << ") ";
 }
@@ -137,7 +137,7 @@ bool operator<(const CDentry& l, const CDentry& r)
 }
 
 
-void CDentry::print(ostream& out)
+void CDentry::print(ostream& out) const
 {
   out << *this;
 }

diff --git a/src/mds/CDentry.h b/src/mds/CDentry.h
index 0d468c6f07428e35ff83989714ccb03ddb4bf378..7a499399673fc51849df73c157c671f9a93e6fa9 100644 (file)
--- a/src/mds/CDentry.h
+++ b/src/mds/CDentry.h
@@ -357,8 +357,8 @@ public:
   void remove_client_lease(ClientLease *r, Locker *locker);  // returns remaining mask (if any), and kicks locker eval_gathers
   void remove_client_leases(Locker *locker);
 
-  std::ostream& print_db_line_prefix(std::ostream& out) override;
-  void print(std::ostream& out) override;
+  std::ostream& print_db_line_prefix(std::ostream& out) const override;
+  void print(std::ostream& out) const override;
   void dump(ceph::Formatter *f) const;
 
   static void encode_remote(inodeno_t& ino, unsigned char d_type,

diff --git a/src/mds/CDir.cc b/src/mds/CDir.cc
index ca0c2ec17f035531afdd16171861cc2e3dc2a635..0484c38cc30304d06b4821ef970d901d36159c87 100644 (file)
--- a/src/mds/CDir.cc
+++ b/src/mds/CDir.cc
@@ -180,7 +180,7 @@ ostream& operator<<(ostream& out, const CDir& dir)
 }
 
 
-void CDir::print(ostream& out) 
+void CDir::print(ostream& out) const
 {
   out << *this;
 }
@@ -188,7 +188,7 @@ void CDir::print(ostream& out)
 
 
 
-ostream& CDir::print_db_line_prefix(ostream& out) 
+ostream& CDir::print_db_line_prefix(ostream& out) const
 {
   return out << ceph_clock_now() << " mds." << mdcache->mds->get_nodeid() << ".cache.dir(" << this->dirfrag() << ") ";
 }

diff --git a/src/mds/CDir.h b/src/mds/CDir.h
index 58507db970b4b3220dc1cc3c29f689de30d8a0bb..7cc4dc7ffcf8379104f061d19bc12572e2f076a4 100644 (file)
--- a/src/mds/CDir.h
+++ b/src/mds/CDir.h
@@ -611,8 +611,8 @@ public:
   }
   void enable_frozen_inode();
 
-  std::ostream& print_db_line_prefix(std::ostream& out) override;
-  void print(std::ostream& out) override;
+  std::ostream& print_db_line_prefix(std::ostream& out) const override;
+  void print(std::ostream& out) const override;
   void dump(ceph::Formatter *f, int flags = DUMP_DEFAULT) const;
   void dump_load(ceph::Formatter *f);
 

diff --git a/src/mds/CInode.cc b/src/mds/CInode.cc
index 839d5fb65668554420b3cb5c0588f2a8e01de4d4..56f5c3e0dda6cd5a5ee0359e3042be41b9c6eee8 100644 (file)
--- a/src/mds/CInode.cc
+++ b/src/mds/CInode.cc
@@ -131,7 +131,7 @@ std::string_view CInode::pin_name(int p) const
 }
 
 //int cinode_pins[CINODE_NUM_PINS];  // counts
-ostream& CInode::print_db_line_prefix(ostream& out)
+ostream& CInode::print_db_line_prefix(ostream& out) const
 {
   return out << ceph_clock_now() << " mds." << mdcache->mds->get_nodeid() << ".cache.ino(" << ino() << ") ";
 }
@@ -338,7 +338,7 @@ CInode::CInode(MDCache *c, bool auth, snapid_t f, snapid_t l) :
     state_set(STATE_AUTH);
 }
 
-void CInode::print(ostream& out)
+void CInode::print(ostream& out) const
 {
   out << *this;
 }

diff --git a/src/mds/CInode.h b/src/mds/CInode.h
index 2f7d6d242b896ee7efbf7174843372696a539b04..5c7e1ab2e323843008323b0f96955751bb1347fc 100644 (file)
--- a/src/mds/CInode.h
+++ b/src/mds/CInode.h
@@ -423,7 +423,7 @@ class CInode : public MDSCacheObject, public InodeStoreBase, public Counter<CIno
 
   std::string_view pin_name(int p) const override;
 
-  std::ostream& print_db_line_prefix(std::ostream& out) override;
+  std::ostream& print_db_line_prefix(std::ostream& out) const override;
 
   const scrub_info_t *scrub_info() const {
     if (!scrub_infop)
@@ -1032,7 +1032,7 @@ class CInode : public MDSCacheObject, public InodeStoreBase, public Counter<CIno
            state_test(STATE_RANDEPHEMERALPIN);
   }
 
-  void print(std::ostream& out) override;
+  void print(std::ostream& out) const override;
   void dump(ceph::Formatter *f, int flags = DUMP_DEFAULT) const;
 
   /**

diff --git a/src/mds/FSMapUser.cc b/src/mds/FSMapUser.cc
index 63a58acc835aa7d07522befcb4de5dbe1273239c..1b58fdbb2f8f62b33f8f14509323cd626323f522 100644 (file)
--- a/src/mds/FSMapUser.cc
+++ b/src/mds/FSMapUser.cc
@@ -62,7 +62,7 @@ void FSMapUser::print(std::ostream& out) const
     out << " id " <<  p.second.cid << " name " << p.second.name << std::endl;
 }
 
-void FSMapUser::print_summary(ceph::Formatter *f, std::ostream *out)
+void FSMapUser::print_summary(ceph::Formatter *f, std::ostream *out) const
 {
   std::map<mds_role_t,std::string> by_rank;
   std::map<std::string,int> by_state;

diff --git a/src/mds/FSMapUser.h b/src/mds/FSMapUser.h
index a0be8e714aff77588573172033a1e20442b08efe..96ac26d6da947fdecd69429894889e74d1de28e4 100644 (file)
--- a/src/mds/FSMapUser.h
+++ b/src/mds/FSMapUser.h
@@ -46,7 +46,7 @@ public:
   void decode(ceph::buffer::list::const_iterator& bl);
 
   void print(std::ostream& out) const;
-  void print_summary(ceph::Formatter *f, std::ostream *out);
+  void print_summary(ceph::Formatter *f, std::ostream *out) const;
 
   static void generate_test_instances(std::list<FSMapUser*>& ls);
 
@@ -57,7 +57,7 @@ public:
 WRITE_CLASS_ENCODER_FEATURES(FSMapUser::fs_info_t)
 WRITE_CLASS_ENCODER_FEATURES(FSMapUser)
 
-inline std::ostream& operator<<(std::ostream& out, FSMapUser& m) {
+inline std::ostream& operator<<(std::ostream& out, const FSMapUser& m) {
   m.print_summary(NULL, &out);
   return out;
 }

diff --git a/src/mds/MDSCacheObject.h b/src/mds/MDSCacheObject.h
index 53d33460bc6f917ecf0b3950e75a3217bac3c0f2..8710102b70d99268881b2af09061b8bbb0f39411 100644 (file)
--- a/src/mds/MDSCacheObject.h
+++ b/src/mds/MDSCacheObject.h
@@ -98,8 +98,8 @@ class MDSCacheObject {
   std::string_view generic_pin_name(int p) const;
 
   // printing
-  virtual void print(std::ostream& out) = 0;
-  virtual std::ostream& print_db_line_prefix(std::ostream& out) { 
+  virtual void print(std::ostream& out) const = 0;
+  virtual std::ostream& print_db_line_prefix(std::ostream& out) const {
     return out << "mdscacheobject(" << this << ") "; 
   }
 
@@ -326,11 +326,7 @@ class MDSCacheObject {
   static uint64_t last_wait_seq;
 };
 
-std::ostream& operator<<(std::ostream& out, const mdsco_db_line_prefix& o);
-// printer
-std::ostream& operator<<(std::ostream& out, const MDSCacheObject &o);
-
-inline std::ostream& operator<<(std::ostream& out, MDSCacheObject &o) {
+inline std::ostream& operator<<(std::ostream& out, const MDSCacheObject& o) {
   o.print(out);
   return out;
 }

diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index 91dd0a3bd7d623755b1f479a4ed1d1009b3fc4df..7ed27c14b10d3d7adb6ac3042fecce04efe6cb6d 100644 (file)
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -138,7 +138,7 @@ public:
     batch_reqs.clear();
     server->reply_client_request(mdr, make_message<MClientReply>(*mdr->client_request, r));
   }
-  void print(std::ostream& o) {
+  void print(std::ostream& o) const override {
     o << "[batch front=" << *mdr << "]";
   }
 };