]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/monc: drop misleading comment about Connection::reply. 39673/head
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Wed, 24 Feb 2021 19:40:56 +0000 (19:40 +0000)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Mon, 1 Mar 2021 15:14:25 +0000 (15:14 +0000)
Before the commit the `crimson::mon:Connection::reply`
was commented as being specific to the ProtocolV1.
However, the code suggests this member participates also
in V2-related paths like `Connection::renew_tickets()`
where `do_auth()` is called from. `do_auth()` generates
`MAuth` which causes a monitor to send `MAuthReply`.
The `Connection::reply` synchronizes sending the auth
request with response handling.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
src/crimson/mon/MonClient.cc

index b7a8023ecb4f772d38668283b0d119705288ac8d..e90d73348ec40e485fed0a0ff1ac1d737ce4ba0d 100644 (file)
@@ -95,7 +95,6 @@ private:
 
 private:
   bool closed = false;
-  // v1
   seastar::shared_promise<Ref<MAuthReply>> reply;
   // v2
   using clock_t = seastar::lowres_system_clock;