]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mon: MonCommands.h: have 'auth' read-only operations require 'x' cap
authorJoao Eduardo Luis <joao.luis@inktank.com>
Thu, 3 Apr 2014 17:21:08 +0000 (18:21 +0100)
committerSage Weil <sage@inktank.com>
Fri, 4 Apr 2014 19:57:50 +0000 (12:57 -0700)
This reintroduces the same semantics that were in place in dumpling prior
to the refactoring of the cap/command matching code.

We haven't added this requirement to auth read-write operations as that
would have the potential to break a lot of well-configured keyrings once
the users upgraded, without any significant gain -- we assume that if
they have set 'rw' caps on a given entity, they are indeed expecting said
entity to be sort-of-privileged entities with regard to monitor access.

Fixes: #7919
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
(cherry picked from commit db266a3fb2985605738201f59f07fa504c91c770)

Conflicts:

doc/release-notes.rst

src/mon/MonCommands.h

index 881c5a252465e04ceb9badd6036d13ab092f8b01..3145fc01dd004bd0abc6467f044c5f15df8d7947 100644 (file)
@@ -149,16 +149,16 @@ COMMAND("pg set_nearfull_ratio name=ratio,type=CephFloat,range=0.0|1.0", \
 
 COMMAND("auth export name=entity,type=CephString,req=false", \
                "write keyring for requested entity, or master keyring if none given", \
-       "auth", "r", "cli,rest")
+       "auth", "rx", "cli,rest")
 COMMAND("auth get name=entity,type=CephString", \
-       "write keyring file with requested key", "auth", "r", "cli,rest")
+       "write keyring file with requested key", "auth", "rx", "cli,rest")
 COMMAND("auth get-key name=entity,type=CephString", "display requested key", \
-       "auth", "r", "cli,rest")
+       "auth", "rx", "cli,rest")
 COMMAND("auth print-key name=entity,type=CephString", "display requested key", \
-       "auth", "r", "cli,rest")
+       "auth", "rx", "cli,rest")
 COMMAND("auth print_key name=entity,type=CephString", "display requested key", \
-       "auth", "r", "cli,rest")
-COMMAND("auth list", "list authentication state", "auth", "r", "cli,rest")
+       "auth", "rx", "cli,rest")
+COMMAND("auth list", "list authentication state", "auth", "rx", "cli,rest")
 COMMAND("auth import", "auth import: read keyring file from -i <file>", \
        "auth", "rw", "cli,rest")
 COMMAND("auth add " \