]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
seastore: add comment to do_transaction outlining ordering TODO
authorSamuel Just <sjust@redhat.com>
Wed, 5 May 2021 05:22:18 +0000 (22:22 -0700)
committerSamuel Just <sjust@redhat.com>
Fri, 7 May 2021 07:39:05 +0000 (00:39 -0700)
Signed-off-by: Samuel Just <sjust@redhat.com>
src/crimson/os/seastore/seastore.cc

index 191ca502ee427526f66c0a6cfb06a01504f04dfc..ee0b791658719eaacc35224bb968367099c0562d 100644 (file)
@@ -556,6 +556,15 @@ seastar::future<> SeaStore::do_transaction(
   CollectionRef _ch,
   ceph::os::Transaction&& _t)
 {
+  /* TODO: add ordering to Collection
+   *
+   * TransactionManager::submit_transction will ensure that
+   * beginning at that point operations remain ordered through
+   * to the jorunal.  We still need a pipeline stage associated
+   * with each collection to ensure that this portion in
+   * SeaStore::do_transaction remains correctly ordered for operations
+   * submitted on the same collection. TODO
+   */
   return repeat_with_internal_context(
     _ch,
     std::move(_t),