]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
qa: move the optional client_config parameter to the end
authorXiubo Li <xiubli@redhat.com>
Thu, 25 Nov 2021 08:29:21 +0000 (16:29 +0800)
committerXiubo Li <xiubli@redhat.com>
Wed, 1 Dec 2021 07:05:58 +0000 (15:05 +0800)
Fixes: https://tracker.ceph.com/issues/53216
Signed-off-by: Xiubo Li <xiubli@redhat.com>
qa/tasks/cephfs/filesystem.py
qa/tasks/cephfs/fuse_mount.py
qa/tasks/vstart_runner.py

index 9e079c9c80c0dcef8a94d768129f9075718c8209..3f9b518a5a1fd386777638e897fd732c88940a67 100644 (file)
@@ -720,7 +720,7 @@ class Filesystem(MDSCluster):
         # avoid circular dep by importing here:
         from tasks.cephfs.fuse_mount import FuseMount
         d = misc.get_testdir(self._ctx)
-        m = FuseMount(self._ctx, {}, d, "admin", self.client_remote, cephfs_name=self.name)
+        m = FuseMount(self._ctx, d, "admin", self.client_remote, cephfs_name=self.name)
         m.mount_wait()
         m.run_shell_payload(cmd)
         m.umount_wait(require_clean=True)
index 8ecaab7b78bba0bda546e24d2b950413fe8814e0..6c82379e26ed885f0d7ca63d21ac9a674ed05190 100644 (file)
@@ -16,15 +16,16 @@ log = logging.getLogger(__name__)
 
 # Refer mount.py for docstrings.
 class FuseMount(CephFSMount):
-    def __init__(self, ctx, client_config, test_dir, client_id,
-                 client_remote, client_keyring_path=None, cephfs_name=None,
-                 cephfs_mntpt=None, hostfs_mntpt=None, brxnet=None):
+    def __init__(self, ctx, test_dir, client_id, client_remote,
+                 client_keyring_path=None, cephfs_name=None,
+                 cephfs_mntpt=None, hostfs_mntpt=None, brxnet=None,
+                 client_config={}):
         super(FuseMount, self).__init__(ctx=ctx, test_dir=test_dir,
             client_id=client_id, client_remote=client_remote,
             client_keyring_path=client_keyring_path, hostfs_mntpt=hostfs_mntpt,
             cephfs_name=cephfs_name, cephfs_mntpt=cephfs_mntpt, brxnet=brxnet)
 
-        self.client_config = client_config if client_config else {}
+        self.client_config = client_config
         self.fuse_daemon = None
         self._fuse_conn = None
         self.id = None
index 9a173846fd6f198e2695648dc33c02c5c39bc908..234ad1985dfb0e159695981ddf52893a29c60ad7 100644 (file)
@@ -713,9 +713,8 @@ class LocalFuseMount(LocalCephFSMount, FuseMount):
     def __init__(self, ctx, test_dir, client_id, client_keyring_path=None,
                  client_remote=None, hostfs_mntpt=None, cephfs_name=None,
                  cephfs_mntpt=None, brxnet=None):
-        super(LocalFuseMount, self).__init__(ctx=ctx, client_config=None,
-            test_dir=test_dir, client_id=client_id,
-            client_keyring_path=client_keyring_path,
+        super(LocalFuseMount, self).__init__(ctx=ctx, test_dir=test_dir,
+            client_id=client_id, client_keyring_path=client_keyring_path,
             client_remote=LocalRemote(), hostfs_mntpt=hostfs_mntpt,
             cephfs_name=cephfs_name, cephfs_mntpt=cephfs_mntpt, brxnet=brxnet)