]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd/osd: handle_osd_map() remove unused ConnectionRef conn
authorMatan Breizman <mbreizma@redhat.com>
Wed, 7 Jun 2023 14:36:37 +0000 (14:36 +0000)
committerMatan Breizman <mbreizma@redhat.com>
Tue, 13 Jun 2023 07:33:56 +0000 (07:33 +0000)
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
src/crimson/osd/osd.cc
src/crimson/osd/osd.h

index 2ec8fc48f6f71c47b9798893334082af876e2d9a..dfb4f1e3e3d0ab1d78a4ab2c1118fd5744e87d19 100644 (file)
@@ -707,7 +707,7 @@ OSD::ms_dispatch(crimson::net::ConnectionRef conn, MessageRef m)
                                                 m=std::move(m), &dispatched] {
     switch (m->get_type()) {
     case CEPH_MSG_OSD_MAP:
-      return handle_osd_map(conn, boost::static_pointer_cast<MOSDMap>(m));
+      return handle_osd_map(boost::static_pointer_cast<MOSDMap>(m));
     case CEPH_MSG_OSD_OP:
       return handle_osd_op(conn, boost::static_pointer_cast<MOSDOp>(m));
     case MSG_OSD_PG_CREATE2:
@@ -853,8 +853,7 @@ bool OSD::require_mon_peer(crimson::net::Connection *conn, Ref<Message> m)
   return true;
 }
 
-seastar::future<> OSD::handle_osd_map(crimson::net::ConnectionRef conn,
-                                      Ref<MOSDMap> m)
+seastar::future<> OSD::handle_osd_map(Ref<MOSDMap> m)
 {
   /* Ensure that only one MOSDMap is processed at a time.  Allowing concurrent
   * processing may eventually be worthwhile, but such an implementation would
@@ -865,15 +864,14 @@ seastar::future<> OSD::handle_osd_map(crimson::net::ConnectionRef conn,
   * simpler invariant for now.
   * See https://tracker.ceph.com/issues/59165
   */
-  return handle_osd_map_lock.lock().then([=, this] {
-    return _handle_osd_map(conn, m);
-  }).finally([=, this] {
+  return handle_osd_map_lock.lock().then([this, m] {
+    return _handle_osd_map(m);
+  }).finally([this] {
     return handle_osd_map_lock.unlock();
   });
 }
 
-seastar::future<> OSD::_handle_osd_map(crimson::net::ConnectionRef conn,
-                                      Ref<MOSDMap> m)
+seastar::future<> OSD::_handle_osd_map(Ref<MOSDMap> m)
 {
   logger().info("handle_osd_map {}", *m);
   if (m->fsid != superblock.cluster_fsid) {
index 1069a4b2f2d8a2e84e4caa24cfd6312d5fdc8590..abf4a00844d3c08141b7d7d3f5ea7239c38cfed3 100644 (file)
@@ -168,10 +168,8 @@ private:
 
   bool require_mon_peer(crimson::net::Connection *conn, Ref<Message> m);
 
-  seastar::future<> handle_osd_map(crimson::net::ConnectionRef conn,
-                                   Ref<MOSDMap> m);
-  seastar::future<> _handle_osd_map(crimson::net::ConnectionRef conn,
-                                    Ref<MOSDMap> m);
+  seastar::future<> handle_osd_map(Ref<MOSDMap> m);
+  seastar::future<> _handle_osd_map(Ref<MOSDMap> m);
   seastar::future<> handle_pg_create(crimson::net::ConnectionRef conn,
                                     Ref<MOSDPGCreate2> m);
   seastar::future<> handle_osd_op(crimson::net::ConnectionRef conn,