]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/cephadm: make 'host add' idempotent
authorSage Weil <sage@newdream.net>
Mon, 3 May 2021 16:04:28 +0000 (12:04 -0400)
committerSage Weil <sage@newdream.net>
Fri, 7 May 2021 12:47:41 +0000 (07:47 -0500)
Do not let prime_empty_host blow away inventory.

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit a8acc354dc7dc1245f5030a751f4fc5ddb689b18)

src/pybind/mgr/cephadm/module.py

index 08813a4653d008da9b25f48fe57c59502c24f819..29373c9e8b87c5ce511bce14ce060b60798eab17 100644 (file)
@@ -1409,8 +1409,9 @@ Then run the following:
                 'args': [f'{k}={v}' for k, v in spec.location.items()],
             })
 
+        if spec.hostname not in self.inventory:
+            self.cache.prime_empty_host(spec.hostname)
         self.inventory.add_host(spec)
-        self.cache.prime_empty_host(spec.hostname)
         self.offline_hosts_remove(spec.hostname)
         self.event.set()  # refresh stray health check
         self.log.info('Added host %s' % spec.hostname)