]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
cmake: fix for -DWITH_BREAKPAD=OFF 66462/head
authorCasey Bodley <cbodley@redhat.com>
Mon, 1 Dec 2025 15:25:16 +0000 (10:25 -0500)
committerCasey Bodley <cbodley@redhat.com>
Mon, 1 Dec 2025 16:26:02 +0000 (11:26 -0500)
in 1ba55a20be1023c585ba96617dc6a9d2aa79a51b, i tried to avoid the NOT
condition by swapping the option's defaults. but when the condition is
false, the option is forced to ON even if the user manually set it OFF

fix this by inverting the condition and swapping the default values

Reported-by: Joseph Mundackal <joseph.j.mundackal@gmail.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
CMakeLists.txt

index 42b8c383f57a321278b52c4c4d92a134dbd38170..546bbef96e377e00bf1760e90e7c2d1eb9981c6d 100644 (file)
@@ -540,8 +540,8 @@ endif()
 
 # enable breakpad unless win32 or power
 # ppc64le port tracked in https://issues.chromium.org/issues/41479970
-CMAKE_DEPENDENT_OPTION(WITH_BREAKPAD "Build with Google Breakpad crash reporter" OFF
-  "WIN32 OR CMAKE_SYSTEM_PROCESSOR MATCHES ppc64le" ON)
+CMAKE_DEPENDENT_OPTION(WITH_BREAKPAD "Build with Google Breakpad crash reporter" ON
+  "NOT (WIN32 OR CMAKE_SYSTEM_PROCESSOR MATCHES ppc64le)" OFF)
 if(WITH_BREAKPAD)
   set(HAVE_BREAKPAD ON)
   message("-- Enabled Google Breakpad crash reporter")