]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
compressor/lz4: use optional<> instead of Tub<>
authorKefu Chai <kchai@redhat.com>
Sun, 14 Feb 2021 07:26:11 +0000 (15:26 +0800)
committerKefu Chai <kchai@redhat.com>
Sun, 14 Feb 2021 08:28:52 +0000 (16:28 +0800)
so we can drop Tub<> once all of its consumers are removed.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/compressor/lz4/LZ4Compressor.h

index dd22bd3876136b4528246806881a9ccb88e3eb17..fed98cec229ed964e3452a337a0b6fd347a8f268 100644 (file)
 #ifndef CEPH_LZ4COMPRESSOR_H
 #define CEPH_LZ4COMPRESSOR_H
 
+#include <optional>
 #include <lz4.h>
 
 #include "compressor/Compressor.h"
 #include "include/buffer.h"
 #include "include/encoding.h"
 #include "common/config.h"
-#include "common/Tub.h"
 
 
 class LZ4Compressor : public Compressor {
@@ -118,11 +118,11 @@ class LZ4Compressor : public Compressor {
 
     ceph::buffer::ptr cur_ptr = p.get_current_ptr();
     ceph::buffer::ptr *ptr = &cur_ptr;
-    Tub<ceph::buffer::ptr> data_holder;
+    optional<ceph::buffer::ptr> data_holder;
     if (compressed_len != cur_ptr.length()) {
-      data_holder.construct(compressed_len);
+      data_holder.emplace(compressed_len);
       p.copy_deep(compressed_len, *data_holder);
-      ptr = data_holder.get();
+      ptr = &*data_holder;
     }
 
     char *c_in = ptr->c_str();